Allow opting out of applying Editor's LeftJoins. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorioBerra
force-pushed
the
tory.berra/feat/search-builder-leftjoin-optout
branch
from
ece781e to
830d29c
Compare
VictorioBerra
force-pushed
the
tory.berra/feat/search-builder-leftjoin-optout
branch
from
830d29c to
5b21624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17
SearchPaneOptions may benefit from applying Editor's left joins, but unless I am missing something big, I don't see why the SearchBuilder would need to be forced to apply unrelated LeftJoins to its various unique options.
This allows opting out, defaults to the current functionality which preserves backwards compatibility.
CC @AllanJard