Skip to content

Commit

Permalink
Adjust isDrawing so directSelect works even when multiSelect is used
Browse files Browse the repository at this point in the history
  • Loading branch information
dopenguin committed Feb 12, 2025
1 parent b165190 commit 2b14181
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions packages/plugins/Gfi/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## unpublished

- Fix: Adjust detection whether a user is drawing so that `directSelect` is not disabled when `multiSelect` is in use.

## 3.0.0

- Breaking: Upgrade `@masterportal/masterportalapi` from `2.40.0` to `2.45.0` and subsequently `ol` from `^9.2.4` to `^10.3.1`.
Expand Down
5 changes: 2 additions & 3 deletions packages/plugins/Gfi/src/store/actions/setupMultiSelection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ const isDrawing = (map: Map) =>
.getArray()
.some(
(interaction) =>
(interaction instanceof Draw &&
// @ts-expect-error | internal hack to detect it from @polar/plugin-gfi and @polar/plugin-draw
(interaction._isMultiSelect || interaction._isDrawPlugin)) ||
// @ts-expect-error | internal hack to detect it from @polar/plugin-draw
(interaction instanceof Draw && interaction._isDrawPlugin) ||
interaction instanceof Modify ||
// @ts-expect-error | internal hack to detect it from @polar/plugin-draw
interaction._isDeleteSelect ||
Expand Down

0 comments on commit 2b14181

Please sign in to comment.