Try modelling every dependency as a dev dependency

Dataport · Mar 8, 2024 · 4ac431c · 4ac431c
1 parent b1d54be
commit 4ac431c
Show file tree

Hide file tree

Showing 17 changed files with 258 additions and 184 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.0.0-alpha.7
+
+- Fix: Model every dependency as a devDependency.
+
 ## 2.0.0-alpha.6
 
 - Fix: Remove vuetify plugin for rollup.

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -31,13 +31,10 @@
     "bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
     "preversion": "npm run bundle"
   },
-  "peerDependencies": {
-    "ol": "^7.1.0",
-    "olcs": "2.13.1"
-  },
-  "dependencies": {
+  "devDependencies": {
     "@fortawesome/fontawesome-free": "^6.2.1",
     "@masterportal/masterportalapi": "2.8.0",
+    "@polar/lib-custom-types": "^1.4.0",
     "@polar/lib-idx": "1.1.0-alpha.1",
     "@polar/lib-get-cluster": "1.1.0-alpha.1",
     "@polar/lib-invisible-style": "1.1.0-alpha.1",
@@ -49,13 +46,12 @@
     "i18next-vue": "^1.1.0",
     "lodash.merge": "^4.6.2",
     "lodash.kebabcase": "^4.1.1",
+    "ol": "^7.1.0",
+    "olcs": "2.13.1",
     "vue": "^2.6.14",
     "vuetify": "^2.5.9",
     "vuex": "^3.6.2"
   },
-  "devDependencies": {
-    "@polar/lib-custom-types": "^1.4.0"
-  },
   "nx": {
     "includedScripts": [
       "bundle"

diff --git a/packages/core/rollup.config.js b/packages/core/rollup.config.js
@@ -23,7 +23,6 @@ const external = createFilter(
     'olcs',
     'vue',
     'vuetify',
-    'vuetify/lib/components',
     'vuex',
   ],
   null,

diff --git a/packages/core/src/components/MapContainer.vue b/packages/core/src/components/MapContainer.vue
@@ -51,7 +51,6 @@ import Hammer from 'hammerjs'
 import i18next from 'i18next'
 import { defaults } from 'ol/interaction'
 import { LanguageOption, MoveHandleProperties } from '@polar/lib-custom-types'
-import { VApp } from 'vuetify/lib/components'
 import { SMALL_DISPLAY_HEIGHT, SMALL_DISPLAY_WIDTH } from '../utils/constants'
 import { addClusterStyle } from '../utils/addClusterStyle'
 import MapUi from './MapUi.vue'
@@ -63,7 +62,6 @@ export default Vue.extend({
   components: {
     MapUi,
     MoveHandle,
-    VApp,
   },
   props: {
     mapConfiguration: {

diff --git a/packages/core/src/components/MoveHandle.vue b/packages/core/src/components/MoveHandle.vue
@@ -23,8 +23,6 @@
 import Vue from 'vue'
 import { mapGetters, mapMutations } from 'vuex'
 
-import { VBtn, VCardActions, VIcon, VSpacer } from 'vuetify/lib/components'
-
 type EndEventName = 'touchend' | 'mouseup'
 type MoveEventName = 'touchmove' | 'mousemove'
 interface MoveEventNames {
@@ -55,12 +53,6 @@ function calculateTop(
 
 export default Vue.extend({
   name: 'MoveHandle',
-  components: {
-    VBtn,
-    VCardActions,
-    VIcon,
-    VSpacer,
-  },
   props: {
     closeLabel: {
       type: String,

diff --git a/packages/plugins/AddressSearch/CHANGELOG.md b/packages/plugins/AddressSearch/CHANGELOG.md
@@ -1,9 +1,13 @@
 # CHANGELOG
 
+## 2.0.0-alpha.4
+
+- Fix: Model every dependency as a devDependency.
+
 ## 2.0.0-alpha.3
 
 - Fix: Remove vuetify plugin for rollup.
-- - Fix: Import vuetify components so they can be externalized by rollup.
+- Fix: Import vuetify components, so they can be externalized by rollup.
 
 ## 2.0.0-alpha.2
 

diff --git a/packages/plugins/AddressSearch/package.json b/packages/plugins/AddressSearch/package.json
@@ -31,21 +31,16 @@
     "bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
     "preversion": "npm run bundle"
   },
-  "peerDependencies": {
+  "devDependencies": {
+    "@polar/lib-custom-types": "^1.0.0",
+    "@polar/lib-get-features": "2.0.0-alpha.1",
     "@masterportal/masterportalapi": "2.8.0",
     "@repositoryname/vuex-generators": "^1.1.2",
+    "lodash.debounce": "^4.0.8",
     "ol": "7.1.0",
     "vue": "^2.6.14",
-    "vuetify": "^2.5.9",
     "vuex": "^3.6.2"
   },
-  "dependencies": {
-    "@polar/lib-get-features": "2.0.0-alpha.1",
-    "lodash.debounce": "^4.0.8"
-  },
-  "devDependencies": {
-    "@polar/lib-custom-types": "^1.0.0"
-  },
   "nx": {
     "includedScripts": [
       "bundle"

diff --git a/packages/plugins/AddressSearch/rollup.config.js b/packages/plugins/AddressSearch/rollup.config.js
@@ -14,7 +14,6 @@ const external = createFilter(
     'lodash.debounce',
     'ol/**',
     'vue',
-    'vuetify/lib/components',
     'vuex',
   ],
   null,

diff --git a/packages/plugins/AddressSearch/src/components/AddressSearch.vue b/packages/plugins/AddressSearch/src/components/AddressSearch.vue
@@ -14,7 +14,6 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import { VContainer, VToolbar } from 'vuetify/lib/components'
 import { mapGetters } from 'vuex'
 import GroupSelect from './GroupSelect.vue'
 import Results from './Results.vue'
@@ -26,8 +25,6 @@ export default Vue.extend({
     GroupSelect,
     SearchInput,
     Results,
-    VContainer,
-    VToolbar,
   },
   computed: {
     ...mapGetters(['clientWidth', 'hasSmallWidth', 'hasWindowSize']),

diff --git a/packages/plugins/AddressSearch/src/components/GroupSelect.vue b/packages/plugins/AddressSearch/src/components/GroupSelect.vue
@@ -21,14 +21,10 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import { VSelect } from 'vuetify/lib/components'
 import { mapGetters, mapActions } from 'vuex'
 
 export default Vue.extend({
   name: 'AddressSearchGroupSelect',
-  components: {
-    VSelect,
-  },
   computed: {
     ...mapGetters('plugin/addressSearch', [
       'selectedGroupId',

diff --git a/packages/plugins/AddressSearch/src/components/Input.vue b/packages/plugins/AddressSearch/src/components/Input.vue
@@ -20,15 +20,11 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import { VTextField } from 'vuetify/lib/components'
 import { mapActions, mapGetters } from 'vuex'
 import { focusFirstResult } from '../utils/focusFirstResult'
 
 export default Vue.extend({
   name: 'AddressSearchInput',
-  components: {
-    VTextField,
-  },
   computed: {
     ...mapGetters('plugin/addressSearch', [
       'featureListsWithCategory',

diff --git a/packages/plugins/AddressSearch/src/components/Results.vue b/packages/plugins/AddressSearch/src/components/Results.vue
@@ -96,28 +96,12 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import {
-  VBtn,
-  VCard,
-  VIcon,
-  VList,
-  VListItem,
-  VSubheader,
-} from 'vuetify/lib/components'
 import { mapGetters, mapActions } from 'vuex'
 import { focusFirstResult } from '../utils/focusFirstResult'
 import { emTitleByInput } from '../utils/emTitleByInput'
 
 export default Vue.extend({
   name: 'AddressSearchResults',
-  components: {
-    VBtn,
-    VCard,
-    VIcon,
-    VList,
-    VListItem,
-    VSubheader,
-  },
   data: () => ({
     openCategories: [] as string[],
   }),

diff --git a/packages/plugins/Gfi/CHANGELOG.md b/packages/plugins/Gfi/CHANGELOG.md
@@ -1,8 +1,9 @@
 # CHANGELOG
 
-## unpublished
+## 2.0.0-alpha.3
 
 - Fix: Remove vuetify plugin for rollup.
+- Fix: Model every dependency as a devDependency.
 
 ## 2.0.0-alpha.2
 

diff --git a/packages/plugins/Gfi/package.json b/packages/plugins/Gfi/package.json
@@ -31,25 +31,21 @@
     "bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
     "preversion": "npm run bundle"
   },
-  "peerDependencies": {
+  "devDependencies": {
     "@masterportal/masterportalapi": "2.8.0",
+    "@polar/lib-custom-types": "^1.2.0",
+    "@polar/lib-get-cluster": "1.1.0-alpha.1",
+    "@polar/lib-invisible-style": "1.1.0-alpha.1",
+    "@polar/lib-test-mount-parameters": "^1.1.0",
+    "@polar/lib-tooltip": "1.1.0-alpha.1",
     "@repositoryname/vuex-generators": "^1.1.2",
+    "just-compare": "^2.3.0",
+    "lodash.debounce": "^4.0.8",
     "i18next": "^23.7.16",
     "ol": "^7.1.0",
     "vue": "^2.6.14",
     "vuex": "^3.6.2"
   },
-  "dependencies": {
-    "@polar/lib-get-cluster": "1.1.0-alpha.1",
-    "@polar/lib-invisible-style": "1.1.0-alpha.1",
-    "@polar/lib-tooltip": "1.1.0-alpha.1",
-    "just-compare": "^2.3.0",
-    "lodash.debounce": "^4.0.8"
-  },
-  "devDependencies": {
-    "@polar/lib-custom-types": "^1.2.0",
-    "@polar/lib-test-mount-parameters": "^1.1.0"
-  },
   "nx": {
     "includedScripts": [
       "bundle"

diff --git a/packages/plugins/Pins/CHANGELOG.md b/packages/plugins/Pins/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.0.0-alpha.2
+
+- Fix: Model every dependency as a devDependency.
+
 ## 2.0.0-alpha.1
 
 - Breaking: As a result of the bundling with `rollup`, the styles of the package need to be imported via `@polar/plugin-pins/styles.css`.

diff --git a/packages/plugins/Pins/package.json b/packages/plugins/Pins/package.json
@@ -27,16 +27,12 @@
     "bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
     "preversion": "npm run bundle"
   },
-  "peerDependencies": {
-    "@repositoryname/vuex-generators": "^1.1.2",
-    "ol": "^7.1.0"
-  },
-  "dependencies": {
-    "@polar/lib-passes-boundary-check": "2.1.0-alpha.1"
-  },
   "devDependencies": {
     "@polar/lib-custom-types": "^1.0.0",
+    "@polar/lib-passes-boundary-check": "2.1.0-alpha.1",
     "@polar/lib-test-mount-parameters": "^1.0.0",
+    "@repositoryname/vuex-generators": "^1.1.2",
+    "ol": "^7.1.0",
     "vue": "^2.6.14"
   },
   "nx": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,6 @@ const external = createFilter( @@
         'olcs',
         'vue',
         'vuetify',
-        'vuetify/lib/components',
         'vuex',
       ],
       null,
@@ Expand Down @@