Import vuetify components so they can be externalized by rollup

Dataport · Mar 8, 2024 · 5955aae · 5955aae
1 parent 63509e4
commit 5955aae
Show file tree

Hide file tree

Showing 12 changed files with 46 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,8 +1,9 @@
 # CHANGELOG
 
-## unpublished
+## 2.0.0-alpha.5
 
 - Fix: Remove vuetify plugin for rollup.
+- Fix: Import vuetify components so they can be externalized by rollup.
 
 ## 2.0.0-alpha.5
 

diff --git a/packages/core/rollup.config.js b/packages/core/rollup.config.js
@@ -23,6 +23,7 @@ const external = createFilter(
     'olcs',
     'vue',
     'vuetify',
+    'vuetify/lib/components',
     'vuex',
   ],
   null,

diff --git a/packages/core/src/components/MapContainer.vue b/packages/core/src/components/MapContainer.vue
@@ -51,6 +51,7 @@ import Hammer from 'hammerjs'
 import i18next from 'i18next'
 import { defaults } from 'ol/interaction'
 import { LanguageOption, MoveHandleProperties } from '@polar/lib-custom-types'
+import { VApp } from 'vuetify/lib/components'
 import { SMALL_DISPLAY_HEIGHT, SMALL_DISPLAY_WIDTH } from '../utils/constants'
 import { addClusterStyle } from '../utils/addClusterStyle'
 import MapUi from './MapUi.vue'
@@ -62,6 +63,7 @@ export default Vue.extend({
   components: {
     MapUi,
     MoveHandle,
+    VApp,
   },
   props: {
     mapConfiguration: {

diff --git a/packages/core/src/components/MoveHandle.vue b/packages/core/src/components/MoveHandle.vue
@@ -23,6 +23,8 @@
 import Vue from 'vue'
 import { mapGetters, mapMutations } from 'vuex'
 
+import { VBtn, VCardActions, VIcon, VSpacer } from 'vuetify/lib/components'
+
 type EndEventName = 'touchend' | 'mouseup'
 type MoveEventName = 'touchmove' | 'mousemove'
 interface MoveEventNames {
@@ -53,6 +55,12 @@ function calculateTop(
 
 export default Vue.extend({
   name: 'MoveHandle',
+  components: {
+    VBtn,
+    VCardActions,
+    VIcon,
+    VSpacer,
+  },
   props: {
     closeLabel: {
       type: String,

diff --git a/packages/plugins/AddressSearch/CHANGELOG.md b/packages/plugins/AddressSearch/CHANGELOG.md
@@ -1,8 +1,9 @@
 # CHANGELOG
 
-## unpublished
+## 2.0.0-alpha.3
 
 - Fix: Remove vuetify plugin for rollup.
+- - Fix: Import vuetify components so they can be externalized by rollup.
 
 ## 2.0.0-alpha.2
 

diff --git a/packages/plugins/AddressSearch/package.json b/packages/plugins/AddressSearch/package.json
@@ -36,6 +36,7 @@
     "@repositoryname/vuex-generators": "^1.1.2",
     "ol": "7.1.0",
     "vue": "^2.6.14",
+    "vuetify": "^2.5.9",
     "vuex": "^3.6.2"
   },
   "dependencies": {

diff --git a/packages/plugins/AddressSearch/rollup.config.js b/packages/plugins/AddressSearch/rollup.config.js
@@ -14,6 +14,7 @@ const external = createFilter(
     'lodash.debounce',
     'ol/**',
     'vue',
+    'vuetify/lib/components',
     'vuex',
   ],
   null,

diff --git a/packages/plugins/AddressSearch/src/components/AddressSearch.vue b/packages/plugins/AddressSearch/src/components/AddressSearch.vue
@@ -14,6 +14,7 @@
 
 <script lang="ts">
 import Vue from 'vue'
+import { VContainer, VToolbar } from 'vuetify/lib/components'
 import { mapGetters } from 'vuex'
 import GroupSelect from './GroupSelect.vue'
 import Results from './Results.vue'
@@ -25,6 +26,8 @@ export default Vue.extend({
     GroupSelect,
     SearchInput,
     Results,
+    VContainer,
+    VToolbar,
   },
   computed: {
     ...mapGetters(['clientWidth', 'hasSmallWidth', 'hasWindowSize']),

diff --git a/packages/plugins/AddressSearch/src/components/GroupSelect.vue b/packages/plugins/AddressSearch/src/components/GroupSelect.vue
@@ -21,10 +21,14 @@
 
 <script lang="ts">
 import Vue from 'vue'
+import { VSelect } from 'vuetify/lib/components'
 import { mapGetters, mapActions } from 'vuex'
 
 export default Vue.extend({
   name: 'AddressSearchGroupSelect',
+  components: {
+    VSelect,
+  },
   computed: {
     ...mapGetters('plugin/addressSearch', [
       'selectedGroupId',

diff --git a/packages/plugins/AddressSearch/src/components/Input.vue b/packages/plugins/AddressSearch/src/components/Input.vue
@@ -20,11 +20,15 @@
 
 <script lang="ts">
 import Vue from 'vue'
+import { VTextField } from 'vuetify/lib/components'
 import { mapActions, mapGetters } from 'vuex'
 import { focusFirstResult } from '../utils/focusFirstResult'
 
 export default Vue.extend({
   name: 'AddressSearchInput',
+  components: {
+    VTextField,
+  },
   computed: {
     ...mapGetters('plugin/addressSearch', [
       'featureListsWithCategory',

diff --git a/packages/plugins/AddressSearch/src/components/Results.vue b/packages/plugins/AddressSearch/src/components/Results.vue
@@ -96,12 +96,28 @@
 
 <script lang="ts">
 import Vue from 'vue'
+import {
+  VBtn,
+  VCard,
+  VIcon,
+  VList,
+  VListItem,
+  VSubheader,
+} from 'vuetify/lib/components'
 import { mapGetters, mapActions } from 'vuex'
 import { focusFirstResult } from '../utils/focusFirstResult'
 import { emTitleByInput } from '../utils/emTitleByInput'
 
 export default Vue.extend({
   name: 'AddressSearchResults',
+  components: {
+    VBtn,
+    VCard,
+    VIcon,
+    VList,
+    VListItem,
+    VSubheader,
+  },
   data: () => ({
     openCategories: [] as string[],
   }),
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,6 +23,7 @@ const external = createFilter( @@
         'olcs',
         'vue',
         'vuetify',
+        'vuetify/lib/components',
         'vuex',
       ],
       null,
@@ Expand Down @@