Skip to content

Commit

Permalink
Remove displayComponent mentions where it is not necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
Softwarecules committed Aug 1, 2024
1 parent c59f501 commit 5c86d2c
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions packages/clients/meldemichel/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## unpublished

- Chore: Change value of `pins.movable` configuration to `'drag'` as using a boolean has been deprecated in a future release.
- Chore: Removed the `displayComponent` attribute for `@polar/plugin-pins` as it is not necessary.

## 1.1.2

Expand Down
1 change: 0 additions & 1 deletion packages/clients/meldemichel/src/addPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const addPlugins = (core, mode: keyof typeof MODE) => {
removeLoading: 'plugin/loadingIndicator/removeLoadingKey',
}),
Pins({
displayComponent: true,
appearOnClick: { show: true, atZoomLevel: 0 },
coordinateSource: 'plugin/addressSearch/chosenAddress',
toastAction: 'plugin/toast/addToast',
Expand Down
1 change: 0 additions & 1 deletion packages/plugins/Pins/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ The usage of `displayComponent` has no influence on the creation of Pins on the
| toastAction | string? | If `boundaryLayerId` is set, and the pin is moved or created outside the boundary, this string will be used as action to send a toast information to the user. If no toast information is desired, leave this field undefined; for testing purposes, you can still find information in the console. |
| toZoomLevel | number? | Zoom level to use on outside input by e.g. address search. Defaults to `0`. |

For details on the `displayComponent` attribute, refer to the [Global Plugin Parameters](../../core/README.md#global-plugin-parameters) section of `@polar/core`.

#### pins.appearOnClick

Expand Down
1 change: 0 additions & 1 deletion packages/plugins/ReverseGeocoder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ This module has been written for the HH WPS service. The return format is custom
| removeLoading | string? | Points to an action in the store; commited with a loading key as payload on finishing reverse geocoding. |
| zoomTo | number? | If specified, plugin zooms to given coordinate after successful reverse geocoding; number indicates maximal zoom level. |

For details on the `displayComponent` attribute, refer to the [Global Plugin Parameters](../../core/README.md#global-plugin-parameters) section of `@polar/core`.

## Store

Expand Down

0 comments on commit 5c86d2c

Please sign in to comment.