Skip to content

Commit

Permalink
Migrate @polar/plugin-icon-menu to the new rollup setup
Browse files Browse the repository at this point in the history
Also, import the styles from the package in all clients.
  • Loading branch information
dopenguin committed Feb 21, 2024
1 parent da95450 commit 74212d7
Show file tree
Hide file tree
Showing 8 changed files with 66 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/clients/afm/src/polar-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import '@polar/plugin-export/styles.css'
import PolarPluginGfi from '@polar/plugin-gfi'
import '@polar/plugin-gfi/styles.css'
import PolarPluginIconMenu from '@polar/plugin-icon-menu'
import '@polar/plugin-icon-menu/styles.css'
import PolarPluginLayerChooser from '@polar/plugin-layer-chooser'
import PolarPluginLegend from '@polar/plugin-legend'
import PolarPluginLoadingIndicator from '@polar/plugin-loading-indicator'
Expand Down
1 change: 1 addition & 0 deletions packages/clients/dish/src/addPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import '@polar/plugin-geo-location/styles.css'
import PolarPluginGfi from '@polar/plugin-gfi'
import '@polar/plugin-gfi/styles.css'
import PolarPluginIconMenu from '@polar/plugin-icon-menu'
import '@polar/plugin-icon-menu/styles.css'
import PolarPluginLayerChooser from '@polar/plugin-layer-chooser'
import PolarPluginLegend from '@polar/plugin-legend'
import PolarPluginLoadingIndicator from '@polar/plugin-loading-indicator'
Expand Down
1 change: 1 addition & 0 deletions packages/clients/generic/src/polar-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import '@polar/plugin-geo-location/styles.css'
import Gfi from '@polar/plugin-gfi'
import '@polar/plugin-gfi/styles.css'
import IconMenu from '@polar/plugin-icon-menu'
import '@polar/plugin-icon-menu/styles.css'
import LayerChooser from '@polar/plugin-layer-chooser'
import Legend from '@polar/plugin-legend'
import LoadingIndicator from '@polar/plugin-loading-indicator'
Expand Down
1 change: 1 addition & 0 deletions packages/clients/meldemichel/src/addPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import '@polar/plugin-attributions/styles.css'
import GeoLocation from '@polar/plugin-geo-location'
import '@polar/plugin-geo-location/styles.css'
import IconMenu from '@polar/plugin-icon-menu'
import '@polar/plugin-icon-menu/styles.css'
import LoadingIndicator from '@polar/plugin-loading-indicator'
import Pins from '@polar/plugin-pins'
import ReverseGeocoder from '@polar/plugin-reverse-geocoder'
Expand Down
1 change: 1 addition & 0 deletions packages/clients/snowbox/src/addPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import '@polar/plugin-geo-location/styles.css'
import Gfi from '@polar/plugin-gfi'
import '@polar/plugin-gfi/styles.css'
import IconMenu from '@polar/plugin-icon-menu'
import '@polar/plugin-icon-menu/styles.css'
import LayerChooser from '@polar/plugin-layer-chooser'
import Legend from '@polar/plugin-legend'
import LoadingIndicator from '@polar/plugin-loading-indicator'
Expand Down
23 changes: 21 additions & 2 deletions packages/plugins/IconMenu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,32 @@
"license": "EUPL-1.2",
"type": "module",
"author": "Dataport AöR <[email protected]>",
"main": "src/index.ts",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"module": "dist/index.js",
"exports": {
".": {
"import": "./dist/index.js",
"require": "./dist/index.js"
},
"./styles.css": {
"import": "./dist/index.css",
"require": "./dist/index.css"
}
},
"repository": {
"type": "git",
"url": "https://github.com/Dataport/polar.git",
"directory": "packages/plugins/IconMenu"
},
"files": [
"src/**/*",
"dist/**",
"CHANGELOG.md"
],
"scripts": {
"bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
"preversion": "npm run bundle"
},
"peerDependencies": {
"@repositoryname/vuex-generators": "^1.1.2",
"i18next": "^23.7.16",
Expand All @@ -24,5 +40,8 @@
"devDependencies": {
"@polar/lib-custom-types": "^1.2.0",
"@polar/lib-test-mount-parameters": "^1.1.0"
},
"nx": {
"includedScripts": ["bundle"]
}
}
33 changes: 33 additions & 0 deletions packages/plugins/IconMenu/rollup.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import commonjs from '@rollup/plugin-commonjs'
import resolve from '@rollup/plugin-node-resolve'
import scss from 'rollup-plugin-scss'
import svg from 'rollup-plugin-svg'
import terser from '@rollup/plugin-terser'
import typescript from 'rollup-plugin-typescript2'
import vue from 'rollup-plugin-vue'

export default {
input: 'src/index.ts',
output: [
{
file: 'dist/index.js',
name: '@polar/plugin-icon-menu',
format: 'es',
sourcemap: 'inline',
},
],
external: ['@repositoryname/vuex-generators', 'i18next', 'vue', 'vuex'],
plugins: [
vue({
defaultLang: { script: 'ts', style: 'scss' },
css: false,
}),
scss({ fileName: 'index.css', sourceMap: true }),
// Types are not checked as typechecking does not work for vue-files with the current version, might be fixable with an upgrade of vue and vuex; see https://github.com/vuejs/vuex/pull/1121.
typescript({ check: false }),
commonjs(),
resolve(),
svg(),
terser(),
],
}
8 changes: 7 additions & 1 deletion packages/plugins/IconMenu/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
{
"extends": "../../../tsconfig.json"
"extends": "../../../tsconfig.json",
"compilerOptions": {
"outDir": "dist",
},
"include": [
"src/**/*"
]
}

0 comments on commit 74212d7

Please sign in to comment.