Skip to content

Commit

Permalink
Merge branch 'main' into documentation/improve-package-descriptions-a…
Browse files Browse the repository at this point in the history
…nd-keywords
  • Loading branch information
dopenguin authored Sep 23, 2024
2 parents 4d86314 + 161e486 commit 84d7c24
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 178 deletions.
1 change: 1 addition & 0 deletions packages/lib/getFeatures/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## unpublished

- Breaking: Upgrade peerDependency of `ol` from `^7.1.0` to `^9.2.4`.
- Breaking: `getGazetteerFeatures` has been removed. All uses within POLAR have been deprecated and replaced. If you still need this function, please refer to the masterportalApi implementation that features it as root export `search`.
- Breaking: `getWfsFeatures` now throws errors if required parameters on the wfs configuration are missing instead of only printing error messages on the console.
- Feature: `getWfsFeatures` now offers the possibility to set custom attributes for the `PropertyIsLike` operator.
- Fix: Properly extend interface `WfsParameters` from `QueryParameters` to reflect actual usage.
Expand Down
50 changes: 0 additions & 50 deletions packages/lib/getFeatures/gazetteer/index.ts

This file was deleted.

124 changes: 0 additions & 124 deletions packages/lib/getFeatures/gazetteer/parse.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/lib/getFeatures/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './types'
export { getGazetteerFeatures } from './gazetteer'
export { getWfsFeatures } from './wfs'
1 change: 1 addition & 0 deletions packages/plugins/AddressSearch/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Feature: There is now a new optional configuration parameter `searchMethods.queryParameters.likeFilterAttributes` for the WfsSearch that allows to add custom key/value pairs which are mapped to attributes of the like filter operator.
- Feature: `AddressSearchState`, `AddressSearchGetters`, and `MpApiParameters` types have been additionally exposed as root export since using packages frequently rely on them.
- Feature: When using the search type `mpapi`, a second search using a wildcard is now being triggered when the first search yielded no results.
- Feature: When navigating through the search results by keyboard, pressing `Escape` will now result in closing the available results. Browser interactions on `Escape` may take precedence (i.e. in fullscreen mode, the browser will exit fullscreen mode instead of letting us use the input).
- Fix: Adjust documentation and types to properly describe optionality of configuration parameters.
- Fix: Use correct getter for `minLength`.
- Fix: `SearchResultSymbols` has been additionally exposed as root export since using packages frequently rely on it.
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/AddressSearch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Currently supported services:

- BKG
- WFS
- Some gazetteers/WFS-G (please request a check or try yourself, not 100% done)
- Hamburg WFS-G (`mpapi`), may fit some WFS-G outside HH, test advised

## Configuration

Expand Down
3 changes: 2 additions & 1 deletion packages/plugins/AddressSearch/src/components/Results.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
:max-height="maxHeight"
:ripple="false"
tabindex="-1"
@keydown.escape.prevent.stop="escapeSelection"
>
<v-list
v-for="(
Expand Down Expand Up @@ -144,7 +145,7 @@ export default Vue.extend({
},
},
methods: {
...mapActions('plugin/addressSearch', ['selectResult']),
...mapActions('plugin/addressSearch', ['selectResult', 'escapeSelection']),
toggle(category: string): void {
this.openCategories =
this.openCategories.indexOf(category) === -1
Expand Down
3 changes: 3 additions & 0 deletions packages/plugins/AddressSearch/src/store/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ export const makeActions = () => {
commit('setSearchResults', SearchResultSymbols.NO_SEARCH)
}
},
escapeSelection({ commit }): void {
commit('setSearchResults', SearchResultSymbols.NO_SEARCH)
},

/**
* `search` is meant for programmatic access. User search is triggered from
Expand Down
2 changes: 1 addition & 1 deletion packages/types/custom/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface LoadingIndicatorConfiguration extends PluginOptions {
}

/** Possible search methods by type */
export type SearchType = 'bkg' | 'gazetteer' | 'wfs' | 'mpapi' | string
export type SearchType = 'bkg' | 'wfs' | 'mpapi' | string

/**
* Additional queryParameters for the GET-Request;
Expand Down

0 comments on commit 84d7c24

Please sign in to comment.