Merge branch 'main' into fix/POLAR-339-no-interactions-in-exports

Dataport · Jul 31, 2024 · 9fea7b9 · 9fea7b9
2 parents 4113b37 + ba32b42
commit 9fea7b9
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 6 deletions.
diff --git a/packages/clients/afm/CHANGELOG.md b/packages/clients/afm/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Feature: This client now supports the `@polar/core`'s field `stylePath`. The usage is documented in the API.md file.
 - Feature: Update icon of `layerChooser` in `iconMenu` to `fa-layer-group` to clear-up the content hidden behind the menu button.
+- Chore: Change value of `pins.movable` configuration to `'drag'` as using a boolean has been deprecated in a future release.
 
 ## 1.0.1
 

diff --git a/packages/clients/afm/example/polar-example.js b/packages/clients/afm/example/polar-example.js
@@ -67,7 +67,7 @@ const mapConfiguration = {
   },
   pins: {
     toZoomLevel: 9,
-    movable: true,
+    movable: 'drag',
     appearOnClick: {
       show: true,
       atZoomLevel: 3,

diff --git a/packages/clients/dish/CHANGELOG.md b/packages/clients/dish/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## unpublished
 
 - Feature: If a user is geolocated outside of the map's extent, the client will inform the user of why geolocation did not take effect via a textbox.
+- Chore: Change value of `pins.movable` configuration to `'drag'` as using a boolean has been deprecated in a future release.
 
 ## 1.1.1
 

diff --git a/packages/clients/dish/src/mapConfig.ts b/packages/clients/dish/src/mapConfig.ts
@@ -208,7 +208,7 @@ export const mapConfiguration = {
   },
   pins: {
     toZoomLevel: 7,
-    movable: true,
+    movable: 'drag',
     style: {
       fill: shBlue,
     },

diff --git a/packages/clients/meldemichel/CHANGELOG.md b/packages/clients/meldemichel/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## unpublished
+
+- Chore: Change value of `pins.movable` configuration to `'drag'` as using a boolean has been deprecated in a future release.
+
 ## 1.1.2
 
 - Chore: Fix bugs via dependency updates.

diff --git a/packages/clients/meldemichel/src/mapConfigurations.ts b/packages/clients/meldemichel/src/mapConfigurations.ts
@@ -104,7 +104,7 @@ const addressSearch: AddressSearchConfiguration = {
 
 const commonPins: Partial<PinsConfiguration> = {
   toZoomLevel: 7,
-  movable: true,
+  movable: 'drag',
   style: {
     fill: hamburgRed,
   },

diff --git a/packages/clients/snowbox/src/mapConfiguration.ts b/packages/clients/snowbox/src/mapConfiguration.ts
@@ -179,7 +179,7 @@ export const mapConfiguration = {
   pins: {
     boundaryLayerId: hamburgBorder,
     toZoomLevel: 9,
-    movable: true,
+    movable: 'drag',
     appearOnClick: {
       show: true,
       atZoomLevel: 0,

diff --git a/packages/plugins/Pins/README.md b/packages/plugins/Pins/README.md
@@ -17,7 +17,7 @@ The usage of `displayComponent` has no influence on the creation of Pins on the
 | boundaryOnError | ('strict' \| 'permissive')? | If the boundary layer check does not work due to loading or configuration errors, style `'strict'` will disable the pins feature, and style `'permissive'` will act as if no boundaryLayerId was set. Defaults to `'permissive'`. |
 | coordinateSource | string? | The pins plugin may react to changes in other plugins. This specifies the path to such store positions. The position must, when subscribed to, return a GeoJSON feature. Please mind that, when referencing another plugin, that plugin must be in `addPlugins` before this one. |
 | initial | initial? | Configuration options for setting an initial pin. |
-| movable | boolean? \| 'drag' \| 'click' \| 'none' | Whether a user may drag and re-click the pin (`drag` or `true`), only re-click it (`click`) or may only be placed programmatically (`none` or `false`). Defaults to 'none'. **Using a boolean for this configuration has been deprecated and will be removed in the next major release.** |
+| movable | boolean \| 'drag' \| 'click' \| 'none'? | Whether a user may drag and re-click the pin (`drag` or `true`), only re-click it (`click`) or may only be placed programmatically (`none` or `false`). Defaults to 'none'. **Using a boolean for this configuration has been deprecated and will be removed in the next major release.** |
 | style | style? | Display style configuration. |
 | toastAction | string? | If `boundaryLayerId` is set, and the pin is moved or created outside the boundary, this string will be used as action to send a toast information to the user. If no toast information is desired, leave this field undefined; for testing purposes, you can still find information in the console. |
 | toZoomLevel | number? | Zoom level to use on outside input by e.g. address search. Defaults to `0`. |

diff --git a/pages/examples/address.html b/pages/examples/address.html
@@ -63,7 +63,7 @@
       pins: {
         coordinateSource: 'plugin/addressSearch/chosenAddress',
         toZoomLevel: 7,
-        movable: true,
+        movable: 'drag',
       },
       reverseGeocoder: {
         url: 'https://geodienste.hamburg.de/HH_WPS',