Merge branch 'update/polar-326_refactor-readme-files' of https://gith…

…ub.com/Dataport/polar into update/polar-326_refactor-readme-files
Dataport · Jul 31, 2024 · a26497a · a26497a
2 parents 6e6688c + 6e2cc14
commit a26497a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Feature: Add new state parameter `mapHasDimensions` to let plugins have a "hook" to react on when the map is ready.
 - Feature: Add `deviceIsHorizontal` as a getter to have a more central place to check if the device is in landscape mode.
 - Fix: Adjust documentation to properly describe optionality of configuration parameters.
+- Fix: Add package `events` as a dependency to fix issue with `xml2js`. See https://github.com/Leonidas-from-XIV/node-xml2js/issues/697 for more information.
 - Chore: Update dependencies to latest versions.
 
 ## 1.4.1

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -20,6 +20,7 @@
     "@polar/lib-invisible-style": "^1.0.0",
     "@repositoryname/noop": "^1.0.6",
     "@repositoryname/vuex-generators": "^1.1.2",
+    "events": "^3.3.0",
     "hammerjs": "2.0.8",
     "i18next": "^23.11.5",
     "i18next-browser-languagedetector": "^8.0.0",

diff --git a/packages/lib/testMountParameters/README.md b/packages/lib/testMountParameters/README.md
@@ -1,4 +1,4 @@
 # createTestMountParameters
 
-This is a helper function for vue testing. It returns fresh `MockParameters`, including a `localVue`, `vuetify`, and `vuex` instance, the latter copying the basic `core` store structure, i.e., having an empty namespaced `plugin` module.   
+This is a helper function for vue testing. It returns fresh `MockParameters`, including a `localVue`, `vuetify`, and `vuex` instance, the latter copying the basic `core` store structure, i.e., having an empty namespaced `plugin` module.  
 This is mostly done to avoid boilerplate code. For regularly used test contents, feel free to extend the returned contents.