Remove vuetify in core to test if vuetify breaks build

Dataport · Mar 13, 2024 · c38fc42 · c38fc42
1 parent 6b97747
commit c38fc42
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 69 deletions.
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.0.0-alpha.11
+
+- Experimental: Remove vuetify in core to test if vuetify breaks build.
+
 ## 2.0.0-alpha.10
 
 - Chore: Add `compileTemplate` to `rollup-plugin-vue`.

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -50,7 +50,6 @@
     "lodash.merge": "^4.6.2",
     "lodash.kebabcase": "^4.1.1",
     "vue": "^2.6.14",
-    "vuetify": "^2.5.9",
     "vuex": "^3.6.2"
   },
   "devDependencies": {

diff --git a/packages/core/rollup.config.js b/packages/core/rollup.config.js
@@ -21,8 +21,6 @@ const external = createFilter(
     'ol/**',
     'olcs',
     'vue',
-    'vuetify',
-    'vuetify/dist/vuetify.min.css',
     'vuex',
   ],
   null,

diff --git a/packages/core/src/components/MapContainer.vue b/packages/core/src/components/MapContainer.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-app class="polar-wrapper" :lang="lang">
+  <div class="polar-wrapper" :lang="lang">
     <transition name="fade">
       <div
         v-if="!hasWindowSize && (noControlOnZoom || oneFingerPan)"
@@ -40,7 +40,7 @@
         <component :is="moveHandle.component" v-bind="moveHandle.props || {}" />
       </template>
     </MoveHandle>
-  </v-app>
+  </div>
 </template>
 
 <script lang="ts">

diff --git a/packages/core/src/components/MoveHandle.vue b/packages/core/src/components/MoveHandle.vue
@@ -7,14 +7,13 @@
     @mousedown.stop="onMouseDown"
     @touchstart.stop="onTouchStart"
   >
-    <v-icon id="polar-move-handle-grip-icon"> fa-grip-lines </v-icon>
-    <v-card-actions>
+    <i id="polar-move-handle-grip-icon" class="fa-grip-lines"></i>
+    <div>
       <slot name="actionButton" />
-      <v-spacer></v-spacer>
-      <v-btn icon small :aria-label="closeLabel" @click="close(true)">
-        <v-icon><slot name="closeIcon">fa-xmark</slot></v-icon>
-      </v-btn>
-    </v-card-actions>
+      <button :aria-label="closeLabel" @click="close(true)">
+        <i class="fa-xmark"><slot name="closeIcon"></slot></i>
+      </button>
+    </div>
     <slot />
   </div>
 </template>

diff --git a/packages/core/src/utils/createMap/index.ts b/packages/core/src/utils/createMap/index.ts
@@ -1,14 +1,12 @@
 import Vue from 'vue'
 import { makeStore } from '../../vuePlugins/vuex'
-import vuetify from '../../vuePlugins/vuetify'
 import language from '../../language'
 import { MapContainer } from '../../components'
 import { CreateOptions, MapInstance } from '../../types'
 import subscribeFunction from './subscribe'
 import { updateSizeOnReady } from './updateSizeOnReady'
 import { makeShadowRoot } from './makeShadowRoot'
 import { pullPolarStyleToShadow } from './pullPolarStyleToShadow'
-import { pullVuetifyStyleToShadow } from './pullVuetifyStyleToShadow'
 import { setupFontawesome } from './setupFontawesome'
 
 /**
@@ -27,7 +25,6 @@ export default async function createMap({
   await language(mapConfiguration?.language)
 
   const instance: MapInstance = new Vue({
-    vuetify: vuetify(mapConfiguration?.vuetify),
     el: shadowRoot.appendChild(document.createElement('div')),
     render: (createElement) =>
       createElement(MapContainer, {
@@ -40,7 +37,6 @@ export default async function createMap({
   instance.subscribe = subscribeFunction
 
   pullPolarStyleToShadow(shadowRoot, mapConfiguration.stylePath)
-  pullVuetifyStyleToShadow(shadowRoot)
   setupFontawesome(shadowRoot, mapConfiguration.renderFaToLightDom)
   updateSizeOnReady(instance)
 

diff --git a/packages/core/src/utils/createMap/pullVuetifyStyleToShadow.ts b/packages/core/src/utils/createMap/pullVuetifyStyleToShadow.ts
diff --git a/packages/core/src/vuePlugins/vuetify.ts b/packages/core/src/vuePlugins/vuetify.ts
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,8 +21,6 @@ const external = createFilter( @@
         'ol/**',
         'olcs',
         'vue',
-        'vuetify',
-        'vuetify/dist/vuetify.min.css',
         'vuex',
       ],
       null,
@@ Expand Down @@