Skip to content

Commit

Permalink
Merge branch main to branch feature/packaging
Browse files Browse the repository at this point in the history
  • Loading branch information
dopenguin committed Apr 3, 2024
2 parents 0eadf35 + 905e636 commit d31df8a
Show file tree
Hide file tree
Showing 16 changed files with 135 additions and 196 deletions.
102 changes: 51 additions & 51 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions packages/clients/meldemichel/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- Chore: Import newly exposed style paths of `@polar/core` as well as all plugin packages.

## 1.0.0-beta.7

- Fix: Use `@polar/[email protected]` to fix the map getting dragged along with the pin in some situations.

## 1.0.0-beta.6

- Feature: Add `@polar/plugin-address-search` and `@polar/plugin-reverse-geocoder` to mode `SINGLE`.
Expand Down
4 changes: 2 additions & 2 deletions packages/clients/meldemichel/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@polar/client-meldemichel",
"version": "1.0.0-beta.6",
"version": "1.0.0-beta.7",
"description": "Client Meldemichel",
"license": "EUPL-1.2",
"type": "module",
Expand Down Expand Up @@ -36,7 +36,7 @@
"@polar/plugin-icon-menu": "^1.1.0",
"@polar/plugin-layer-chooser": "^1.1.0",
"@polar/plugin-loading-indicator": "^1.0.1",
"@polar/plugin-pins": "^1.1.1",
"@polar/plugin-pins": "^1.3.1",
"@polar/plugin-reverse-geocoder": "^1.0.1",
"@polar/plugin-scale": "^1.0.1",
"@polar/plugin-toast": "^1.0.1",
Expand Down
4 changes: 0 additions & 4 deletions packages/plugins/Attributions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

This plugin shows attributions (that is, legal information) regarding copyrights and sources of the currently visible layers.

### Extension ideas

- Offer a mode where attributions are always visible. (Not on roadmap.)

## Configuration

### attributions
Expand Down
31 changes: 0 additions & 31 deletions packages/plugins/Gfi/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,37 +6,6 @@ The GFI plugin can be used to fetch and optionally display GFI (GetFeatureInfo)

> ⚠️ The display feature is currently not meant for production. Please use data bindings for display to avoid obstructing the map client.
### Extension ideas

- To ease the currently rather complex WMS GFI parsing, we may send a WMS
GetCapabilities request during initialization to detect supported formats by
services. We may then proceed to choose from the offered formats and have the
parser ready from the get-go. This would also allow for printing error
messages for unspecified formats during start-up time, and for choosing a
better format should the first named (and therefore used by default) format be
unhandy, e.g. be an arbitrary text response.

- Currently, the specification on how to display a GFI is taken from the
mapConfiguration object. The Masterportal does support GFI instructions
specified on the layer definitions within the services.json file itself. That
specification is documented, but a little more complex, and ignored for now,
since we're going for a more configurable client – our users will, in general,
be interested in _one specific layer_, not any layer that might display GFI.

However, we may still support that one day by e.g. a configuration parameter
`useServicesDefinition::boolean`.

- Any entry may be a callback rather than an object/definition

- Display links as `<a ...>Click to open</a>`

- Optionally filter to visible layers

- Reduce features to a single window rather
than showing each feature individually
- By function parameter
- By definition

### Configuration

#### gfi
Expand Down
4 changes: 0 additions & 4 deletions packages/plugins/IconMenu/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ It is meant for additional information/functionality (legend, other layers) or p

_Please note that the average user has never seen the client before and just wants to get done with it, not learn a map client._

### Extension ideas

- Content configurability during mapConfiguration (not on roadmap)

## Configuration

> ⚠️ This plugin can't be configured with the `mapConfiguration`, but is configured during client construction. Currently, no way exists to add plugins to it after the build took place.
Expand Down
4 changes: 0 additions & 4 deletions packages/plugins/LoadingIndicator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

A generic loading indicator that may be used by any plugin or outside procedure to indicate loading.

### Extension ideas

- More styles (currently not on roadmap)

## Store

### Mutations
Expand Down
4 changes: 4 additions & 0 deletions packages/plugins/Pins/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Fix: Revert back to previous dependency modelling.
- Breaking: As a result of the bundling with `rollup`, the styles of the package need to be imported via `@polar/plugin-pins/styles.css`.
- Feature: The package is now being bundled by `rollup` before being published. This allows for a smaller package size and better compatibility with other packages.

## 1.3.1

- Fix: The map dragged along with the pin in some situations, rendering the pin effectively immovable. This has been fixed.

## 1.3.0

- Feature: Pins can now be re-initialized with the `setupInitial` action. This is an advanced feature currently only available when coding clients.
Expand Down
4 changes: 0 additions & 4 deletions packages/plugins/Pins/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

The pins plugin handles marking locations. Embedding processes can then use that coordinate for further steps. The plugin may react to other plugins, especially address searches.

### Extension ideas

- Allow multiple pins

## Configuration

The usage of `displayComponent` has no influence on the creation of Pins on the Map if this plugin is being used.
Expand Down
18 changes: 18 additions & 0 deletions packages/plugins/Pins/src/store/getters.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { PolarGetterTree } from '@polar/lib-custom-types'
import { generateSimpleGetters } from '@repositoryname/vuex-generators'
import { PinsGetters, PinsState } from '../types'
import { getInitialState } from './state'

const getters: PolarGetterTree<PinsState, PinsGetters> = {
...generateSimpleGetters(getInitialState()),
toZoomLevel(_, __, ___, rootGetters) {
return (rootGetters.configuration.pins || {}).toZoomLevel || 0
},
atZoomLevel(_, __, ___, rootGetters) {
return (
(rootGetters.configuration.pins || {}).appearOnClick?.atZoomLevel || 0
)
},
}

export default getters
Loading

0 comments on commit d31df8a

Please sign in to comment.