Add proper packaging using rollup to all plugins, core and lib packages #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added concurrently as a first step towards good DX regarding HMR.
All defined styles need to be imported before the shadowDOM is created to ensure they are reachable by the map client.
Also, add respective nx:watch script and concurrently to all dev scripts.
Also, add concurrently and nx:watch to all client dev scripts.
All the required packages bundle tasks are executed whenever the dev task is run. This can not be enabled via npm workspaces without additional steps. Also, cache all the results of the bundle tasks to not recalculate results after the dev task is restarted.
Also, remove all nx-provided plugins included installed peerDependencies as they won't be used anyway.
Also, import the styles from the core package in all clients.
dopenguin
force-pushed
the
main
branch
2 times, most recently
from
294e1ae to
b8f7025
Compare
This was referenced Jan 24, 2025
|
To be able to yield a benefit from the changes introduced in this PR, either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rollupto be able to use each package outside of this repository (I will add example repositories once this PR is merged)lernahas been removed in favour ofnpm workspacesnxis used for task schedulingtsc --noEmittask in the pipeline would be a good idea, after we fixed the type issues in the client code as well, @warm-coolguy?Instructions for local reproduction and review
All clients and every functionality are affected by the changes. Thus, all clients should be tested in
devas well as inprod(build) mode.If you got any questions while testing, feel free to ask me any time (I understand that the changes are quite extensive)...
TODO
Relevant tickets, issues, et cetera
#107 has to be merged before this PR