Feature/add new mode for attributions #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'footer' as a renderType is not really fitting as it is possible to place the information box anywhere in the map, but I could not think of a better term. Changelog: As in "Masterportal", I used "Unreleased" as topic. I'm not sure if this is the correct procedure for POLAR? |
dopenguin
reviewed
Jul 5, 2024
packages/plugins/Attributions/src/components/AttributionContent.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new renderType 'footer' was added that displays a small, non-closing information box.
Instructions for local reproduction and review
Configuration of the Attribution Plugin with the renderType 'footer'. The attributions will be displayed wherever it is placed within the layout as smaller version of the information box.