Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused dependencies #143

Merged
merged 5 commits into from
Jul 23, 2024
Merged

remove unused dependencies #143

merged 5 commits into from
Jul 23, 2024

Conversation

warm-coolguy
Copy link
Member

Summary

  • "events" is still installed as dependency of another dependency. However, it is not a direct dependency, and thus has been removed.
  • SBOM generation did not work and the sbom is outdated and thus misleading. The file and package have been removed. An SBOM mechanism is in development at https://github.com/Dataport/polar/tree/feature/provide-sbom in parallel.

Instructions for local reproduction and review

No tests required.

@warm-coolguy warm-coolguy added the refactor Refactoring of previous code label Jul 12, 2024
@warm-coolguy warm-coolguy self-assigned this Jul 12, 2024
dopenguin
dopenguin approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dopenguin dopenguin merged commit 492b12f into main Jul 23, 2024
1 check passed
@dopenguin dopenguin deleted the refactor/remove-unused-dependencies branch July 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopenguin dopenguin dopenguin approved these changes

Assignees

@warm-coolguy warm-coolguy

Labels
refactor Refactoring of previous code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warm-coolguy @dopenguin