Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POLAR-362 Update deprecated boolean of movable parameter to enum value #148

Merged
merged 6 commits into from
Jul 31, 2024
Merged

POLAR-362 Update deprecated boolean of movable parameter to enum value #148

merged 6 commits into from
Jul 31, 2024

Conversation

Softwarecules
Copy link
Contributor

@Softwarecules Softwarecules commented Jul 30, 2024 •
edited by dopenguin
Loading

Summary

Use of movable with boolean has been deprecated - The client configs and the examples have been updated to reflect this and now use an enum value as default.

Instructions for local reproduction and review

Run the examples for dish, afm and meldemichel respectively and examine the pin-behaviour. It should work as intended and be dragable.

Relevant tickets, issues, et cetera

#145

Blocked by #147

@Softwarecules Softwarecules added the refactor Refactoring of previous code label Jul 30, 2024
@Softwarecules Softwarecules self-assigned this Jul 30, 2024
dopenguin
dopenguin requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a required change to the README.md and also suggested some slight adjustments for the changelog entries.

🏓 @Softwarecules

@dopenguin dopenguin added the documentation Improvements or additions to documentation label Jul 30, 2024
@dopenguin dopenguin linked an issue Jul 30, 2024 that may be closed by this pull request
Usage of deprecated boolean value for movable #145
Closed
@Softwarecules Softwarecules requested a review from dopenguin July 31, 2024 08:35
@Softwarecules
Copy link
Contributor Author

Added a required change to the README.md and also suggested some slight adjustments for the changelog entries.

🏓 @Softwarecules

Applied the suggested changes :)
🏓 @dopenguin

dopenguin
dopenguin reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve inbound as soon as #147 has been merged to main @Softwarecules

@Softwarecules
Copy link
Contributor Author

Approve inbound as soon as #147 has been merged to main @Softwarecules

@dopenguin #147 merged 🫡

dopenguin
dopenguin approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @Softwarecules

@Softwarecules Softwarecules merged commit ba32b42 into main Jul 31, 2024
1 check passed
@Softwarecules Softwarecules deleted the update/polar-362_pins-movable-update branch July 31, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopenguin dopenguin dopenguin approved these changes

@warm-coolguy warm-coolguy Awaiting requested review from warm-coolguy warm-coolguy is a code owner

Assignees

@Softwarecules Softwarecules

Labels
documentation Improvements or additions to documentation refactor Refactoring of previous code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of deprecated boolean value for movable
2 participants
@Softwarecules @dopenguin