Fix interface extendedMasterportalapiMarkers to align with documentation #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedi-of-the-sea
requested review from
warm-coolguy and
dopenguin
as code owners
jedi-of-the-sea
changed the title
warm-coolguy
requested changes
Jan 27, 2025
There was a problem hiding this comment.
🏓 @jedi-of-the-sea Nice fix. I found some more related stuff, see comments.
Co-authored-by: Dennis Sen <[email protected]>
Co-authored-by: Dennis Sen <[email protected]>
Co-authored-by: Dennis Sen <[email protected]>
|
🏓 @warm-coolguy I implemented the proposed changes but I cannot get rid of the linting error.. did I overlook something? |
|
NOTE: This seems to be a problem resolved after #211 is merged, where a fix resides. It's a setup thing where the project somehow doesn't install the newest (present) version. |
…align-with-documentation
warm-coolguy
approved these changes
Jan 30, 2025
…align-with-documentation
jedi-of-the-sea
deleted the
fix/extendedMasterportalapiMarkers-edits-to-align-with-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Edit parameters in interface
ExtendedMasterportalapiMarkersso that it fits the documentation (change parameters to optional, type fixes):Instructions for local reproduction and review
Compare documentation of README with new interface edits, it should fit the description.
Pull Request Checklist (for Reviewee)
Rest of the checklist doesn't apply.