-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix that drawings on top of each other were glued #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big step-up to the implementation before!
However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins.
If no features completely overlap, the feature works great though!
packages/plugins/Draw/src/store/createInteractions/createModifyInteractions.ts
Outdated
Show resolved
Hide resolved
packages/plugins/Draw/src/store/createInteractions/createModifyInteractions.ts
Outdated
Show resolved
Hide resolved
packages/plugins/Draw/src/store/createInteractions/createModifyInteractions.ts
Outdated
Show resolved
Hide resolved
Oh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway? |
As it currently works that a feature can be modified, even if it is overlapped by another, I suggest that this issue is tackled as part of this PR as well as we'd just introduce a new bug otherwise. |
The new behaviour is actually a feature since completely overlapped geometries have an additional feeling of depth to them indicating FeatureCollection order now that they can't be edited. If framed as bug, I'd argue it's the better bug. Who needs two polygons anyway ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big step-up to the implementation before! However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins. If no features completely overlap, the feature works great though!
🏓 @warm-coolguyOh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway?
🏓 @dopenguinAs it currently works that a feature can be modified, even if it is overlapped by another, I suggest that this issue is tackled as part of this PR as well as we'd just introduce a new bug otherwise.
🏓 @warm-coolguyThe new behaviour is actually a feature since completely overlapped geometries have an additional feeling of depth to them indicating FeatureCollection order now that they can't be edited. If framed as bug, I'd argue it's the better bug. Who needs two polygons anyway ...
After discussion we agreed that this will be merged and the new bug will be tackled later on
@warm-coolguy
Summary
Made stacked vertices in Draw feature separatable again.
Instructions for local reproduction and review
Test in snowbox with
npm run snowbox
. Stack feature vertices; the edit operation now allows for their separation again.Pull Request Checklist (for Assignee)
SafariScreenreader functionality has been manually tested with NVDAnot relevant to ScreenReaderAn additional (unrelated) bug was found on mobile device and reported to #227.
UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)Chrome LighthouseFirefox Accessibility