Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that drawings on top of each other were glued #228

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

warm-coolguy
Copy link
Member

@warm-coolguy warm-coolguy commented Jan 31, 2025

Summary

Made stacked vertices in Draw feature separatable again.

Instructions for local reproduction and review

Test in snowbox with npm run snowbox. Stack feature vertices; the edit operation now allows for their separation again.

Pull Request Checklist (for Assignee)

  • Changelogs are maintained
  • Functionality has been tested in Firefox, Chrome, Safari
  • Functionality has been tested on a smartphone
  • Functionality has been tested with 200% screen zoom
  • Screenreader functionality has been manually tested with NVDA not relevant to ScreenReader

An additional (unrelated) bug was found on mobile device and reported to #227.

UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)

  • Chrome Lighthouse
  • Firefox Accessibility

@warm-coolguy warm-coolguy added the bug Something isn't working label Jan 31, 2025
@warm-coolguy warm-coolguy self-assigned this Jan 31, 2025
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big step-up to the implementation before!
However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins.
If no features completely overlap, the feature works great though!

🏓 @warm-coolguy

@warm-coolguy
Copy link
Member Author

This is a big step-up to the implementation before! However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins. If no features completely overlap, the feature works great though!

🏓 @warm-coolguy

Oh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway?

🏓 @dopenguin

@dopenguin
Copy link
Member

This is a big step-up to the implementation before! However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins. If no features completely overlap, the feature works great though!
🏓 @warm-coolguy

Oh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway?

🏓 @dopenguin

As it currently works that a feature can be modified, even if it is overlapped by another, I suggest that this issue is tackled as part of this PR as well as we'd just introduce a new bug otherwise.

🏓 @warm-coolguy

@warm-coolguy
Copy link
Member Author

This is a big step-up to the implementation before! However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins. If no features completely overlap, the feature works great though!
🏓 @warm-coolguy

Oh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway?
🏓 @dopenguin

As it currently works that a feature can be modified, even if it is overlapped by another, I suggest that this issue is tackled as part of this PR as well as we'd just introduce a new bug otherwise.

🏓 @warm-coolguy

The new behaviour is actually a feature since completely overlapped geometries have an additional feeling of depth to them indicating FeatureCollection order now that they can't be edited. If framed as bug, I'd argue it's the better bug. Who needs two polygons anyway ...

🏓 @dopenguin

Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big step-up to the implementation before! However, if a geometry is on top of another geometry, the geometry that is placed under the other one can either a) not be edited at all and has no indicator for that either or b) the indicator is present but the editing only sometimes begins. If no features completely overlap, the feature works great though!
🏓 @warm-coolguy

Oh, yeah. I see. I have no fix idea for that. Maybe it's not relevant? Shall we merge anyway?
🏓 @dopenguin

As it currently works that a feature can be modified, even if it is overlapped by another, I suggest that this issue is tackled as part of this PR as well as we'd just introduce a new bug otherwise.
🏓 @warm-coolguy

The new behaviour is actually a feature since completely overlapped geometries have an additional feeling of depth to them indicating FeatureCollection order now that they can't be edited. If framed as bug, I'd argue it's the better bug. Who needs two polygons anyway ...

🏓 @dopenguin

After discussion we agreed that this will be merged and the new bug will be tackled later on
:shipit: @warm-coolguy

@warm-coolguy warm-coolguy merged commit 7a34d6e into main Feb 6, 2025
4 checks passed
@warm-coolguy warm-coolguy deleted the fix/separate-stacked-drawings branch February 6, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants