-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add translate mode to draw #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionally to editing features, they can now be moved as-are
…/add-translate-mode-to-draw
…om/Dataport/polar into feature/add-translate-mode-to-draw
dopenguin
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things, not much to change, looks and works good!
packages/plugins/Draw/src/store/createInteractions/createModifyInteractions.ts
Show resolved
Hide resolved
packages/plugins/Draw/src/store/createInteractions/createTranslateInteractions.ts
Outdated
Show resolved
Hide resolved
dopenguin
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor suggestion and two questions so we can go with
apply suggestion "live in the now" Co-authored-by: Pascal Röhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A translate option has been added to the Draw interactions.
Instructions for local reproduction and review
Run snowbox and translate freshly drawn features.
Pull Request Checklist (for Assignee)
SafariUI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
Regarding a11y, no new warnings have been added.