Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translate mode to draw #235

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Conversation

warm-coolguy
Copy link
Member

Summary

A translate option has been added to the Draw interactions.

Instructions for local reproduction and review

Run snowbox and translate freshly drawn features.

Pull Request Checklist (for Assignee)

  • Changelogs are maintained
  • Functionality has been tested in Firefox, Chrome, Safari
  • Functionality has been tested on a smartphone
  • Functionality has been tested with 200% screen zoom
  • Screenreader functionality has been manually tested with NVDA

UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)

  • Chrome Lighthouse
  • Firefox Accessibility

Regarding a11y, no new warnings have been added.

additionally to editing features, they can now be moved as-are
@warm-coolguy warm-coolguy added the enhancement New feature or request label Feb 13, 2025
@warm-coolguy warm-coolguy self-assigned this Feb 13, 2025
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things, not much to change, looks and works good!

🏓 @warm-coolguy

Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor suggestion and two questions so we can go with

:shipit: @warm-coolguy

apply suggestion "live in the now"

Co-authored-by: Pascal Röhling <[email protected]>
@warm-coolguy warm-coolguy merged commit 3243a9c into main Feb 14, 2025
4 checks passed
@warm-coolguy warm-coolguy deleted the feature/add-translate-mode-to-draw branch February 14, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants