add lasso logic to draw #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Dataport/polar into feature/add-lasso-logic-to-draw
dopenguin
requested changes
Feb 20, 2025
packages/plugins/Draw/src/store/createInteractions/createLassoInteractions.ts
Outdated
Show resolved
Hide resolved
apply suggestion "clarify a little" Co-authored-by: Pascal Röhling <[email protected]>
warm-coolguy
commented
Feb 20, 2025
apply suggestion "remove outdated sentence"
1 task
|
…/add-lasso-logic-to-draw
…/add-lasso-logic-to-draw
dopenguin
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Almost finished with the review, but will tackle
packages/plugins/Draw/src/store/createInteractions/createLassoInteractions.tswith a fresh head.
🏓 @warm-coolguy
packages/plugins/Draw/src/store/createInteractions/createLassoInteractions.ts
Show resolved
Hide resolved
packages/plugins/Draw/src/store/createInteractions/createLassoInteractions.ts
Outdated
Show resolved
Hide resolved
dopenguin
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
The last two comments don't seem to be as relevant to the PR, so I'll leave this here already.
@warm-coolguy
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is currently done without UI.
Instructions for local reproduction and review
Run
diplan:devto check whether the feature works. A button has been added there above the map to allow enabling the lasso function. When drawing that lasso zoomed in to a level that would suffice to display the configured parcel cells, all parcel cells completely covered by the drawn lasso will be copied up to the draw layer.Pull Request Checklist (for Assignee)
UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)