Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare diplan example folder for multiple prod instances #251

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

warm-coolguy
Copy link
Member

Summary

I've split the example setup so that we have a dev client and a prod client that may now deviate. More prod clients are supposed to trickle in over time so that we can easily produce multiple examples regarding the various contained features. With this, it is no longer required to keep the dev and prod .html files in sync.

For the time being, the two clients are mostly copies of each other except for the code source. This will change during the course of the development to follow.

Instructions for local reproduction and review

Check both dev mode and the produced pages.

@warm-coolguy warm-coolguy added the refactor Refactoring of previous code label Feb 27, 2025
@warm-coolguy warm-coolguy self-assigned this Feb 27, 2025
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing big to say, sounds like a good idea.

🏓 @warm-coolguy

warm-coolguy and others added 3 commits February 27, 2025 11:36
apply suggestion "it's not, but we can remove jokes, sure"

Co-authored-by: Pascal Röhling <[email protected]>
add link to GitHub page
@warm-coolguy
Copy link
Member Author

Nothing big to say, sounds like a good idea.

🏓 @warm-coolguy

🏓 @dopenguin

Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warm-coolguy warm-coolguy merged commit f620323 into main Feb 27, 2025
4 checks passed
@warm-coolguy warm-coolguy deleted the refactor/multiple-diplan-clients branch February 27, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of previous code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants