style: forbid { ns: literal } for t calls via ESLint#752
style: forbid { ns: literal } for t calls via ESLint#752oeninghe-dataport wants to merge 1 commit into
Conversation
oeninghe-dataport
requested review from
czirkelbach,
dopenguin,
raschju and
warm-coolguy
as code owners
|
There was a problem hiding this comment.
Can this be made auto-fixable? I'm sure @warm-coolguy would really enjoy that!
Also, if I add a literal in a template, this rule does not raise an issue.
There was a problem hiding this comment.
While I would really enjoy that, I don't think it's plausible to invest that amount of time. Also confirming it doesn't work in templates and there's a lot of templates with the issue present.
Suggestion: We drop the extra rule and just search for ns: ' and replace it in every file and call it a day.
Pro: Saves time and we have another nice thing to nag about in future PRs.
Con: There is none and it won't stop anybody from just declaring the string locally anyway. I'll just find creative ways to annoy you if you proceed.
warm-coolguy
left a comment
warm-coolguy
left a comment
There was a problem hiding this comment.
I request the change "Close pull request".
|
Superseded by #804 |
3 participants
Summary
Forbid { ns: literal } for t calls via ESLint
Relevant tickets, issues, et cetera
Fixes #508
Blocked by #750