refactor: polar select#807
Merged
Merged
Conversation
dopenguin
requested review from
czirkelbach,
oeninghe-dataport and
raschju
as code owners
|
Also, remove shadowing of variables and redundant defaults for props.
dopenguin
force-pushed
the
vue3/refactor-polar-select
branch
from
4fd032a to
6a1ed67
Compare
warm-coolguy
previously approved these changes
Jun 23, 2026
warm-coolguy
left a comment
warm-coolguy
left a comment
Member
There was a problem hiding this comment.
I may have interfered with the implementation. You may want to check back on my fiddling before merging.
…w prop in PolarSelect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PolarSelectnow usesdefineModelin favour of the previousemitsolution.Instructions for local reproduction and review
All adjusted plugins should still work without any issues.