Introduce stylelint#808
Open
oeninghe-dataport wants to merge 2 commits into
Open
Conversation
oeninghe-dataport
requested review from
czirkelbach,
dopenguin,
raschju and
warm-coolguy
as code owners
oeninghe-dataport
added
bug
|
Collaborator
Author
|
In a larger circle, we decided to introduce stylelint. Pre-condition is to have a "green" PR with no errors here. |
oeninghe-dataport
force-pushed
the
introduce-stylelint
branch
from
c8c26a7 to
917093e
Compare
Collaborator
Author
|
@dopenguin The pre-condition for this PR is reached. I adapted the variables to match KERN 2.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As seen various times now (e.g., here), it is probably helpful to have a linter that detects if CSS variables are actually valid.
Therefore, this PR introduces the CSS linter
stylelint.Additional hints
Currently, the pipeline fails due to missing CSS variables from KERN.
Instructions for local reproduction and review
Run
npm run lint:css