remove wildcard on street search #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see added file `scripts/overrideMasterportalapi.js` for details
dopenguin
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Just one small thing, works like a charm otherwise!
Great catch! 🏓 @warm-coolguy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See added file's
scripts/overrideMasterportalapi.jsfor details. While this is a global change, I decided to document it in the Meldemichel, since it's the only client using this right now and the change results in a new Meldemichel beta release.To save you the search, https://bitbucket.org/geowerkstatt-hamburg/masterportalapi/src/master/src/searchAddress/searchGazetteer.js is the file's current state. In case of masterportalapi update, we can do this properly.
Instructions for local reproduction and review
Install (to trigger postinstall) and run the
client:meldemichel:dev. Should the changes not arrive, it may be required to add--forceto the vite command in the root package.json once to avoid vite's cache, which plausibly does not detect manual module changes.An interesting search is for "Roonstraße". This produced plausible results in the previous Meldemichel (and on current /prod), but produces weird results on the /stage system ("Liliencronstraße").