Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin is bundling all of its dependencies unnecessarily, meaning they are included twice #66

Closed
rubiesonthesky opened this issue Jan 24, 2025 · 0 comments · Fixed by #69
Labels
bug Something isn't working

Comments

@rubiesonthesky
Copy link

Describe the bug

This plugin's package size is 16.5 MB according to npm https://www.npmjs.com/package/@smarttools/eslint-plugin-rxjs

It seems that esbuild config uses "bundle: true" setting: https://github.com/DaveMBush/eslint-plugin-rxjs/blob/main/packages/eslint-plugin-rxjs/project.json

This means that the code from dependencies are bundled with the plugin but same time those dependencies are defined in package.json. This means that the dependencies will be installed to node modules but the used code is already bundled in the plugin! For libraries, I don't think you should use bundle option but let users install the dependencies with their package manager.

Screenshots
If applicable, add screenshots to help explain your problem.

Repro
Version of @smarttools/eslint-plugin-rxjs you are using:

Repository that has a reproduction of the problem:

Note: providing a link to a reproduction of the problem will speed the resolution. It no only helps us see what the problem is and verify that it has been fixed, it helps us create a tests that we can run to verify no changes in the future bring the issue back.

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant