Fix Quaternion::to_euler#2
Open
Ceiphos wants to merge 1 commit into
Open
Conversation
Owner
|
TY for the PR! I need to think on the Euler change. I suspect this may have something to do with conflicting conventions. If you create a PR with the SIMD fix; I will merge that; looks good! |
Contributor
Author
|
👍 |
Ceiphos
force-pushed
the
fix-quaternion-to-euler
branch
from
7b6d515 to
99082d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I played around with the crate and noticed an issue with
Quaternion::to_euler. I had a look at the linked blog post, fixed the implementation and added some more test cases.Note: The test
test_simd_rotate_vecis currently failing. As far as I can tell this is due to a mix up of the components of the expectedangledvector in the testcase. If you want I can fix this in this PR as well or do a separate PR.