Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Typescript support ShapeBlur #37

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Added Typescript support ShapeBlur #37

merged 7 commits into from
Jan 27, 2025

Conversation

saj13h
Copy link
Contributor

@saj13h saj13h commented Jan 27, 2025

No description provided.

Added Shape Blur Tail wind code example.
ts code for shape blur component.
default and tailwind.
@DavidHDev
Copy link
Owner

@saj13h Thanks for this! Before I merge it, did you make sure to test these TS components? Just asking for peace of mind 💯

@saj13h
Copy link
Contributor Author

saj13h commented Jan 27, 2025

i tested and it works but there is a compile error showing.

message: Could not find a declaration file for module 'three'. '/Users/saj13h/Desktop/nexttailwindtest/node_modules/three/build/three.module.js' implicitly has an 'any' type.
Try npm i --save-dev @types/three if it exists or add a new declaration (.d.ts) file containing declare module 'three';

there is a quick fix for it but i don't know it is the way:
is installing a package : npm i --save-dev @types/three

even without this package it works but with annoying msg

@DavidHDev
Copy link
Owner

@saj13h that should be fine, three has no TS support out of the box as far as I know, so there's not much we can do about it! Could you maybe add a comment at the top of the TS files to share this info?

@DavidHDev
Copy link
Owner

DavidHDev commented Jan 27, 2025

And one last thing, I've just updated how the code snippets work in the repo, you can see the details here: #34

We no longer have to include separate snippets in the code constants file, just follow the example I gave in the issue 🙏

Please pull the changes on main and see how other code snippets are handled

@DavidHDev
Copy link
Owner

Thanks for the contribution! 💯

@DavidHDev DavidHDev merged commit ff86814 into DavidHDev:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants