Refacto MetricMapper

DeGraciaMathieu · Nov 14, 2024 · 6977ee9 · 6977ee9
1 parent 08aa3dc
commit 6977ee9
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/app/Presenter/Analyze/Class/Shared/MetricMapper.php b/app/Presenter/Analyze/Class/Shared/MetricMapper.php
@@ -4,20 +4,13 @@
 
 use App\Application\Analyze\AnalyzeMetric;
 
-/**
- * @todo : its work but it's not efficient
- */
 class MetricMapper
 {
     public function from(array $metrics): array
     {
-        $class = [];
-
-        foreach ($metrics as $metric) {
-            $class[] = $this->makeClass($metric);
-        }
-
-        return $class;
+        return array_map(function (AnalyzeMetric $metric) {
+            return $this->makeClass($metric);
+        }, $metrics);
     }
 
     private function makeClass(AnalyzeMetric $metric): Metric