Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reefscape forms #442

Merged
merged 43 commits into from
Feb 13, 2025
Merged

Reefscape forms #442

merged 43 commits into from
Feb 13, 2025

Conversation

Tr01ler
Copy link
Contributor

@Tr01ler Tr01ler commented Feb 11, 2025

No description provided.

@Tr01ler Tr01ler self-assigned this Feb 11, 2025
Copy link
Contributor

@renatodellosso renatodellosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd find something to nitpick, but I didn't. I am going to run Reefscape locally and test it out.

Fantastic job! Congrats on your first PR.

Do bump the version to 1.2.0.

@renatodellosso
Copy link
Contributor

renatodellosso commented Feb 11, 2025

We need to sort seasons. (Done)
image

@renatodellosso
Copy link
Contributor

In the Auto header in pit reports, change it to "Auto (describe further in comments)" or something along those lines.

@renatodellosso
Copy link
Contributor

renatodellosso commented Feb 11, 2025

In quant reports, the auto labels don't need to say auto. It's clear enough with the big "Auto" header. Same for teleop.

@renatodellosso
Copy link
Contributor

Check your score calculations. They seem very high.

@Tr01ler Tr01ler merged commit 0cc7590 into main Feb 13, 2025
8 checks passed
@Tr01ler Tr01ler deleted the reefscape branch February 13, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants