Skip to content

Commit

Permalink
fix: security updates (#36)
Browse files Browse the repository at this point in the history
* fix: updates packages to resolve security warnings

* fix: runs prettier

* ci: fixes to jest config (#37)
  • Loading branch information
Andrew T. Poe authored Jul 17, 2019
1 parent e5b2e66 commit c7bfb25
Show file tree
Hide file tree
Showing 3 changed files with 1,363 additions and 1,233 deletions.
18 changes: 13 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"test": "jest",
"test:coverage:report": "open-cli coverage/lcov-report/index.html",
"lint:ci": "eslint --format junit -o reports/junit/js-lint-results.xml src/**",
"test:ci": "cross-env JEST_JUNIT_OUTPUT=reports/junit/js-test-results.xml jest --ci --testResultsProcessor='./node_modules/jest-junit'"
"test:ci": "jest --ci"
},
"peerDependencies": {
"prop-types": "^15.4.0",
Expand Down Expand Up @@ -78,18 +78,17 @@
"babel-eslint": "^10.0.1",
"babel-jest": "^24.7.1",
"concurrently": "^4.1.0",
"cross-env": "^5.0.5",
"eslint": "^5.16.0",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-config-prettier": "^4.2.0",
"eslint-import-resolver-typescript": "^1.1.1",
"eslint-plugin-import": "^2.17.2",
"eslint-plugin-jest": "^22.5.1",
"eslint-plugin-prettier": "^3.1.0",
"husky": "^1.3.1",
"husky": "^3.0.0",
"jest": "^24.8.0",
"jest-junit": "^6.4.0",
"lint-staged": "^8.1.7",
"lint-staged": "^9.2.0",
"opn-cli": "^5.0.0",
"prettier": "^1.17.1",
"prop-types": "^15.6.0",
Expand Down Expand Up @@ -119,7 +118,16 @@
"lines": 90,
"statements": 90
}
}
},
"reporters": [
"default",
[
"jest-junit",
{
"output": "reports/junit/js-test-results.xml"
}
]
]
},
"lint-staged": {
"*.{js*,ts*}": [
Expand Down
23 changes: 10 additions & 13 deletions src/styleModifierPropTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,20 +99,17 @@ export function validateResponsiveModifiers(
const rawInvalidModifiers: string[][] = [];
const rawSizesWithErrors: string[] = [];

forIn(
responsiveModifiers,
(modifiers, size): void => {
const invalidModifiers = getInvalidModifiers(
modifiers as ModifierKeys,
modifierConfig,
);
forIn(responsiveModifiers, (modifiers, size): void => {
const invalidModifiers = getInvalidModifiers(
modifiers as ModifierKeys,
modifierConfig,
);

if (invalidModifiers.length > 0) {
rawInvalidModifiers.push(invalidModifiers);
rawSizesWithErrors.push(size);
}
},
);
if (invalidModifiers.length > 0) {
rawInvalidModifiers.push(invalidModifiers);
rawSizesWithErrors.push(size);
}
});

const invalidModifiers = uniq(flatten(rawInvalidModifiers));
const sizesWithErrors = uniq(rawSizesWithErrors);
Expand Down
Loading

0 comments on commit c7bfb25

Please sign in to comment.