Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save window state #220

Merged
merged 5 commits into from
Apr 18, 2024
Merged

save window state #220

merged 5 commits into from
Apr 18, 2024

Conversation

nhymxu
Copy link
Contributor

@nhymxu nhymxu commented Mar 22, 2024

πŸ“– Description

Closes #207

  1. include a summary of the changes and the related issue, eg. Closes #XYZ
  2. Do not make a PR if you can't check all the boxes below

πŸ› οΈ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://defguard.gitbook.io) first and attach the link to the documentation section in this pool request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have performed manual tests manually and all changes work
  • New and existing unit tests pass locally with my changes

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@teon teon requested a review from filipslezaklab March 23, 2024 07:15
@teon
Copy link
Contributor

teon commented Mar 23, 2024

Thank you @nhymxu for your support and contribution 🫑πŸ’ͺ
@filipslezaklab could you do the review?

@j-chmielewski j-chmielewski merged commit d4cc496 into DefGuard:main Apr 18, 2024
2 checks passed
@nhymxu nhymxu deleted the window-size branch May 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS client resizes window unexpectedly
3 participants