Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix updating the dns server address on client #242

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

t-aleksander
Copy link
Contributor

@t-aleksander t-aleksander commented Jun 18, 2024

πŸ“– Description

Dns details from updated location should now be copied during the update.

fixes #222

πŸ› οΈ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://defguard.gitbook.io) first and attach the link to the documentation section in this pool request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have performed manual tests manually and all changes work
  • New and existing unit tests pass locally with my changes

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@t-aleksander t-aleksander self-assigned this Jun 18, 2024
@t-aleksander t-aleksander merged commit e8a5116 into dev Jun 18, 2024
2 checks passed
@t-aleksander t-aleksander deleted the fix-dns-update branch June 18, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants