Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated favorite item endpoint #460

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Updated favorite item endpoint #460

merged 2 commits into from
Feb 7, 2024

Conversation

floriegl
Copy link
Contributor

@floriegl floriegl commented Feb 7, 2024

Pull Request Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker images successfully? make images
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

(cherry picked from commit ccc01cf)
@floriegl
Copy link
Contributor Author

floriegl commented Feb 7, 2024

Fixes #459 (Currently having issues and not really the time to get peotry working to run all the run configs, but it works on my own instance without issues and the code did not change any logic)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (bc79e7c) 64.67% compared to head (e1d0f24) 64.70%.
Report is 23 commits behind head on dev.

Files Patch % Lines
tgtg_scanner/models/config.py 47.36% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #460      +/-   ##
==========================================
+ Coverage   64.67%   64.70%   +0.02%     
==========================================
  Files          26       26              
  Lines        2231     2244      +13     
==========================================
+ Hits         1443     1452       +9     
- Misses        788      792       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Der-Henning Der-Henning merged commit 4fc462f into Der-Henning:dev Feb 7, 2024
21 of 22 checks passed
@Der-Henning
Copy link
Owner

Thank you for your fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants