Skip to content

CAD DTM Rendering #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

CAD DTM Rendering #186

wants to merge 77 commits into from

Conversation

Erfan-Ahmadi
Copy link
Contributor

@Erfan-Ahmadi Erfan-Ahmadi commented Mar 25, 2025 •
edited
Loading

CAD DTM Rendering Example
Devsh-Graphics-Programming/Nabla#858

@Erfan-Ahmadi Erfan-Ahmadi mentioned this pull request Mar 25, 2025
Open
Erfan-Ahmadi
Erfan-Ahmadi commented Mar 26, 2025
View reviewed changes
62_CAD/shaders/main_pipeline/common.hlsl Outdated
};

// Set 0 - Scene Data and Globals, buffer bindings don't change the buffers only get updated
[[vk::binding(0, 0)]] ConstantBuffer<Globals> globals : register(b0);
[[vk::binding(1, 0)]] StructuredBuffer<DrawObject> drawObjects : register(t0);
[[vk::binding(2, 0)]] StructuredBuffer<MainObject> mainObjects : register(t1);
[[vk::binding(3, 0)]] StructuredBuffer<LineStyle> lineStyles : register(t2);
[[vk::binding(4, 0)]] StructuredBuffer<DTMSettings> dtmSettingsBuff : register(t3);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small rename, just dtmSettings

Erfan-Ahmadi
Erfan-Ahmadi commented Mar 26, 2025
View reviewed changes
Erfan-Ahmadi
Erfan-Ahmadi commented Apr 23, 2025
View reviewed changes
62_CAD/shaders/main_pipeline/dtm.hlsl Outdated
// TODO: functions outside of the "dtm" namespace need to be moved to another file

// for usage in upper_bound function
struct StyleAccessor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these to line_style.hlsl, and include it here
these aren't related to dtms

Erfan-Ahmadi
Erfan-Ahmadi commented Apr 23, 2025
View reviewed changes
62_CAD/shaders/main_pipeline/dtm.hlsl Outdated
return dot(vec, vec);
}

// TODO: Later move these functions and structs to dtmSettings.hlsl and a namespace like dtmSettings::height_shading or dtmSettings::contours, etc..
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

Przemog1 and others added 18 commits April 23, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Przemog1 Przemog1 Przemog1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erfan-Ahmadi @Przemog1