Unit tests and benchmark for subgroup2 and workgroup2 stuff #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intended to replace #190 due to rearranging/renaming of examples |
Comment on lines
+94
to
+95
| add_subdirectory(74_Arithmetic2Bench EXCLUDE_FROM_ALL) | ||
|
|
There was a problem hiding this comment.
take nr 29 for it
Comment on lines
+4
to
+5
| #include "nbl/builtin/hlsl/subgroup/basic.hlsl" | ||
| #include "nbl/builtin/hlsl/subgroup/arithmetic_portability.hlsl" |
There was a problem hiding this comment.
don't include non subgroup2 headers
Comment on lines
+19
to
+22
| // unfortunately DXC chokes on descriptors as static members | ||
| // https://github.com/microsoft/DirectXShaderCompiler/issues/5940 | ||
| [[vk::binding(0, 0)]] StructuredBuffer<type_t> inputValue; | ||
| [[vk::binding(1, 0)]] RWByteAddressBuffer output[8]; |
There was a problem hiding this comment.
can you make the test use BDA so its simpler (no descriptor sets, just BDA sent via push constants)
Comment on lines
-141
to
-173
| const auto spirv_isa_cache_path = localOutputCWD/"spirv_isa_cache.bin"; | ||
| // enclose to make sure file goes out of scope and we can reopen it | ||
| { | ||
| smart_refctd_ptr<const IFile> spirv_isa_cache_input; | ||
| // try to load SPIR-V to ISA cache | ||
| { | ||
| ISystem::future_t<smart_refctd_ptr<IFile>> fileCreate; | ||
| m_system->createFile(fileCreate,spirv_isa_cache_path,IFile::ECF_READ|IFile::ECF_MAPPABLE|IFile::ECF_COHERENT); | ||
| if (auto lock=fileCreate.acquire()) | ||
| spirv_isa_cache_input = *lock; | ||
| } | ||
| // create the cache | ||
| { | ||
| std::span<const uint8_t> spirv_isa_cache_data = {}; | ||
| if (spirv_isa_cache_input) | ||
| spirv_isa_cache_data = {reinterpret_cast<const uint8_t*>(spirv_isa_cache_input->getMappedPointer()),spirv_isa_cache_input->getSize()}; | ||
| else | ||
| m_logger->log("Failed to load SPIR-V 2 ISA cache!",ILogger::ELL_PERFORMANCE); | ||
| // Normally we'd deserialize a `ICPUPipelineCache` properly and pass that instead | ||
| m_spirv_isa_cache = m_device->createPipelineCache(spirv_isa_cache_data); | ||
| } | ||
| } | ||
| { | ||
| // TODO: rename `deleteDirectory` to just `delete`? and a `IFile::setSize()` ? | ||
| m_system->deleteDirectory(spirv_isa_cache_path); | ||
| ISystem::future_t<smart_refctd_ptr<IFile>> fileCreate; | ||
| m_system->createFile(fileCreate,spirv_isa_cache_path,IFile::ECF_WRITE); | ||
| // I can be relatively sure I'll succeed to acquire the future, the pointer to created file might be null though. | ||
| m_spirv_isa_cache_output=*fileCreate.acquire(); | ||
| if (!m_spirv_isa_cache_output) | ||
| logFail("Failed to Create SPIR-V to ISA cache file."); | ||
| } | ||
|
|
There was a problem hiding this comment.
this was a very useful cache, please restore
There was a problem hiding this comment.
it was also a test of the caching mechanism itself
| @@ -457,6 +477,9 @@ class ArithmeticUnitTestApp final : public application_templates::BasicMultiQueu | |||
| smart_refctd_ptr<ICPUBuffer> resultsBuffer; | |||
|
|
|||
| uint32_t totalFailCount = 0; | |||
|
|
|||
| constexpr static inline std::array<uint32_t, 4> WorkgroupSizes = { 32, 256, 512, 1024 }; | |||
There was a problem hiding this comment.
you need all powers of two from 4 to 2048
Comment on lines
+36
to
+37
| template<template<class> class binop, typename T, uint32_t N> | ||
| static void subtest(NBL_CONST_REF_ARG(type_t) sourceVal) |
There was a problem hiding this comment.
grab a binop thats already instantiated (use vector_traits on type_t to get your scalar type), and get the T out of it
N you can also get with vector traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.