feat: 인트로, 헤더 레이아웃 1.5차 완성 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
아 지금 종속성 관련 파일 잘못 건든 것 같습니다. |
karpitony
requested changes
Feb 13, 2025
| </S.TextBlock> | ||
| <S.Nav> | ||
| <S.NavList> | ||
| <li><a href="#home">홈</a></li> |
There was a problem hiding this comment.
헤더 라우팅이 잘못된 것 같습니다...
저희 헤더가 두개가 있는데 디자인 해주신건 최상단 헤더같은데 초기 세팅해주신 헤더는 두번째 헤더(목차)인것 같습니다.
이부분 고쳐주시면 머지해도 될 것 같습니다!!
추후 수빈님 PR까지 머지하면 팝업을 공통 컴포넌트로 분리하는 방안도 좋아보입니다!
There was a problem hiding this comment.
네 지금 일정으로 인해 밖이라, 오늘 밤까지 해결하겠습니다! 감사합니다:)
There was a problem hiding this comment.
네 지금 일정으로 인해 밖이라, 오늘 밤까지 해결하겠습니다! 감사합니다:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
✅ 체크리스트
스크린샷 (선택)
2025-02-13.10.00.01.mov