Initial Akkoma support #2253
Open
Initial Akkoma support #2253
+42
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time using Swift, please be patient with me :)
I've added some initial support for Akkoma here. You can browse pretty much everything just fine. Most of the incompatibilities were caused by keys not existing in Akkoma which are required by IceCubes. Another notable issue was that the endpoint to register apps can't handle being passed query parameters, so I've switched to using a JSON body- Very very unsure about how I'm doing that though, it works but having no experience with Swift I'm doubtful I've done this the best.
I'm aware of at least one thing remaining, and I don't doubt other problems exist too- In the logs, I was getting errors about the notification push endpoint not being supported.
I think this is pretty usable, just needing some polishing up to actually do things "correctly". Let me know!