Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add dev dependency & update build.yml #334

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

svnv
Copy link
Member

@svnv svnv commented Feb 27, 2024

Ref. https://github.com/Dintero/Dintero.Checkout.Web.SDK/actions/runs/8061936439
Rel. #332
Rel. #332 (review)

Add new dependency used by build. Also updates build actions from version @3 to @4 to handle warnings:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@svnv svnv requested a review from andersem February 27, 2024 12:07
@svnv svnv self-assigned this Feb 27, 2024
@svnv svnv requested a review from frodeaa as a code owner February 27, 2024 12:07
Copy link
Contributor

@frodeaa frodeaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the new dependency needed when there is no change in the build.xml related to it?

@andersem
Copy link
Contributor

why is the new dependency needed when there is no change in the build.xml related to it?

Because of #332

@svnv svnv force-pushed the add-semantic-release-exec-plugin branch from b51b694 to bc1142a Compare February 28, 2024 10:04
@svnv svnv merged commit e7d2c7b into master Feb 28, 2024
1 check passed
@svnv svnv deleted the add-semantic-release-exec-plugin branch February 28, 2024 11:05
Copy link

🎉 This PR is included in version 0.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants