-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext.commands): add LargeRange #857
Conversation
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Emre Terzioglu <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Emre Terzioglu <[email protected]>
After reading the comments that @shiftinv has left, I think the best course of action is to leave Range as it currently is. Instead, add a new class called LargeRange (name can be bikeshedded), which switches between the two if needed. In addition, this is large by default, but can switch to float or int if the max is below the threshold. LargeFloat would not be needed, as it would be a part of LargeRange (again, bikeshed name) So to summarize, my proposed changes are:
|
e31a082
to
15a955a
Compare
As of pyright 1.1.299, using non-generic metaclasses with |
Summary
This PR adds support for large numbers (numbers bigger than 2 ** 53 or smaller than -2 ** 53) in a version of
commands.Range
namedcommands.LargeRange
.Checklist
task lint
task pyright