Skip to content

Improve MailingOut's Notification Field: Add Scrollable Wrapper for Long Notifications #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

MULTidll
Copy link
Contributor

@MULTidll MULTidll commented May 17, 2025

Description
This PR enhances the usability of the "notifications" field in the CRM mailing list admin(addresses and fixes the issue #213). If the notification (report) contains 20 or more lines, it is now displayed in a scrollable, fixed-height box . This prevents long error logs from cluttering the admin interface and improves readability for users/admins managing large mailings with many error messages.

@MULTidll MULTidll changed the title Improve MailingOutAdmin Notification Field: Add Scrollable Wrapper for Long Notifications Improve MailingOut's Notification Field: Add Scrollable Wrapper for Long Notifications May 17, 2025
@DjangoCRM DjangoCRM added needs review Pull requests that require code review and approval python Pull requests that update python code labels May 18, 2025
@DjangoCRM
Copy link
Owner

DjangoCRM commented May 19, 2025

@MULTidll Thanks!
The text scrolls well. But the scroll bar is not visible. Therefore, there is no sign that there is more text than is visible and it can be scrolled.
Another question - is it necessary to fix the field width unless this is a forced measure? The fact is that the column width is calculated by Django each time depending on the content.

@DjangoCRM DjangoCRM added the requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again label May 19, 2025
@MULTidll
Copy link
Contributor Author

The width of the scroll bar can be increased i will do that and about the field width it is not necessary but fixing the width to 500px helps control the layout and makes sure the content doesnt stretch too wide
and the content wraps perfectly within that given width

@DjangoCRM
Copy link
Owner

Unfortunately, it hasn't gotten any better.
Django calculates the column widths without assuming that one of them now has a fixed width.
On my screen filled with real field values, the Notification field extends beyond the frame. Therefore, its right side with the scrollbar is not visible.
Now there is a horizontal scroll bar at the bottom of the page.
It looks like we need to abandon the constant field width.

@MULTidll
Copy link
Contributor Author

yeh got it, just now checked it and removed the fixed width

@DjangoCRM DjangoCRM merged commit 0055fdd into DjangoCRM:main May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull requests that require code review and approval python Pull requests that update python code requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants