Catch additional edge case in the counts API #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A search for only a user that doesn't exist like "from:10", doesn't return any data, just immediately creates a response with a meta key indicating there are zero matching tweets. This conflicts with the workaround to catch early termination of counts, and was leading to errors being raised. This change now differentiates between the two failure modes, by checking if any rows of data have been returned previously, or if this is an immediate early termination like happens when a user doesn't exist anymore.
igorbrigadir
approved these changes
Apr 8, 2022
|
I hope they fix this in the API itself later, but we definitely can't wait for them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A search for only a user that doesn't exist like "from:10", doesn't
return any data, just immediately creates a response with a meta
key indicating there are zero matching tweets. This conflicts with
the workaround to catch early termination of counts, and was leading
to errors being raised.
This change now differentiates between the two failure modes,
by checking if any rows of data have been returned previously,
or if this is an immediate early termination like happens when
a user doesn't exist anymore.
Closes #615, at least partly - there may be other edge cases lurking.