Inclusion of AWS type validation #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 96.95% 96.39% -0.57%
==========================================
Files 10 10
Lines 624 638 +14
Branches 128 132 +4
==========================================
+ Hits 605 615 +10
- Misses 12 14 +2
- Partials 7 9 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
dhutchison
changed the title
shadycuz
added
enhancement
|
@dhutchison Unfortunately the Cloudformation docs are not only vague, they are often flat-out wrong. See #179 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of parameter validation for AWS parameter types.
The biggest problem with this has been finding regex patterns for these parameters - the docs are pretty vague and I've had to make a few assumptions. It would be good to validate these against more real examples - currently just using the examples from the AWS parameter type page as the happy path values as well as some examples taken from the AWS CLI docs.
Relates to #202