Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Unit test to "Unit" dir and add a Feature test. #37

Merged
merged 13 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
'whitespace_after_comma_in_array' => true,
])
->setFinder(PhpCsFixer\Finder::create()
->exclude(['vendor', 'tests/Http/Responses/metadata'])
->exclude(['vendor', 'tests/Unit/Http/Responses/metadata'])
->in(__DIR__)
)
;
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"require-dev": {
"roave/security-advisories": "dev-latest",
"friendsofphp/php-cs-fixer": "^3.52",
"phpunit/phpunit": "^10.0",
"phpunit/phpunit": "^10.5",
"larastan/larastan": "^2.9",
"orchestra/testbench": "^8.9|^9.0",
"phpstan/phpstan-phpunit": "^1.3",
Expand All @@ -47,7 +47,8 @@
"vimeo/psalm": "^5.23",
"psalm/plugin-laravel": "^2.10",
"psalm/plugin-phpunit": "^0.19",
"infection/infection": "^0.27.10"
"infection/infection": "^0.27.10",
"laravel/framework": "^10.48"
},
"scripts": {
"lint": "parallel-lint --exclude .git --exclude vendor .",
Expand Down
11 changes: 8 additions & 3 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@
<text outputFile="php://stdout" showUncoveredFiles="false"/>
</report>
</coverage>
<testsuite name="Laravel-JMS-Serializer">
<directory suffix="Test.php">tests</directory>
</testsuite>
<testsuites>
<testsuite name="Unit">
<directory suffix="Test.php">./tests/Unit</directory>
</testsuite>
<testsuite name="Feature">
<directory suffix="Test.php">tests/Feature</directory>
</testsuite>
</testsuites>
<source>
<include>
<directory suffix=".php">src</directory>
Expand Down
72 changes: 72 additions & 0 deletions tests/Feature/ServiceProviderTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Feature;

use Dropelikeit\LaravelJmsSerializer\Contracts\ResponseBuilder;
use Dropelikeit\LaravelJmsSerializer\Http\Responses\ResponseFactory;
use Dropelikeit\LaravelJmsSerializer\ServiceProvider;
use Illuminate\Config\Repository;
use Illuminate\Foundation\Application;
use Illuminate\Support\Facades\Storage;
use PHPUnit\Framework\TestCase;

final class ServiceProviderTest extends TestCase
{
private readonly Application $application;

public function setUp(): void
{
parent::setUp();

$configRepository = $this
->getMockBuilder(Repository::class)
->disableOriginalConstructor()
->getMock();

$configRepository
->expects(self::once())
->method('set')
->with('laravel-jms-serializer', [
'serialize_null' => true,
'serialize_type' => 'json', // Contracts\Config::SERIALIZE_TYPE_XML
'debug' => false,
'add_default_handlers' => true,
'custom_handlers' => [],
]);

$configRepository
->expects(self::exactly(6))
->method('get')
->willReturnOnConsecutiveCalls([], true, 'json', false, true, []);

Storage::shouldReceive('exists')->once()->with(__DIR__ . '/data/storage/framework/cache/data')->andReturn(true);

$this->application = new Application();
$this->application->useStoragePath(__DIR__ . '/data/storage');

$this->application->bind('config', fn () => $configRepository);

$this->application->register(ServiceProvider::class);
}

/**
* @test
*/
public function canBuildResponseFactoryByIdFromConfiguredServiceProvider(): void
{
$responseFactory = $this->application->get('ResponseFactory');

$this->assertInstanceOf(ResponseBuilder::class, $responseFactory);
}

/**
* @test
*/
public function canBuildResponseFactoryByClassConfiguredServiceProvider(): void
{
$responseFactory = $this->application->get(ResponseFactory::class);

$this->assertInstanceOf(ResponseBuilder::class, $responseFactory);
}
}
Empty file added tests/Feature/data/.gitkeep
Empty file.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Config;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\Config;

use Dropelikeit\LaravelJmsSerializer\Config\Config;
use Dropelikeit\LaravelJmsSerializer\Contracts\CustomHandlerConfiguration;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Facades;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\Facades;

use Dropelikeit\LaravelJmsSerializer\Facades\ResponseFactoryFacade;
use PHPUnit\Framework\TestCase;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Http\Responses;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\Http\Responses;

use Dropelikeit\LaravelJmsSerializer\Config\Config;
use Dropelikeit\LaravelJmsSerializer\Contracts;
use Dropelikeit\LaravelJmsSerializer\Exception\SerializeType;
use Dropelikeit\LaravelJmsSerializer\Http\Responses\ResponseFactory;
use Dropelikeit\LaravelJmsSerializer\Serializer\Factory;
use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Dummy;
use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\JsonDummy;
use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Response;
use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\XmlDummy;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\Dummy;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\JsonDummy;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\Response;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\XmlDummy;
use Illuminate\Http\Response as LaravelResponse;
use InvalidArgumentException;
use JMS\Serializer\SerializationContext;
Expand Down Expand Up @@ -90,7 +90,7 @@ public function canCreateFromArrayIterator(): void

$responseFactory = new ResponseFactory((new Factory())->getSerializer($this->config), $this->config);

$response = $responseFactory->create(Response::create([new \Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Response\Item()]));
$response = $responseFactory->create(Response::create([new Response\Item()]));

self::assertEquals(200, $response->getStatusCode());
self::assertEquals('[{"key":"magic_number","value":12}]', $response->getContent());
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Serializer;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\Serializer;

use DateTime;
use Dropelikeit\LaravelJmsSerializer\Config\Config;
use Dropelikeit\LaravelJmsSerializer\Contracts\CustomHandlerConfiguration;
use Dropelikeit\LaravelJmsSerializer\Serializer\Factory;
use Dropelikeit\LaravelJmsSerializer\Tests\Serializer\data\CustomHandler;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\Serializer\data\CustomHandler;
use InvalidArgumentException;
use JMS\Serializer\Context;
use JMS\Serializer\Handler\HandlerRegistry;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\Serializer\data;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\Serializer\data;

use Dropelikeit\LaravelJmsSerializer\Contracts\CustomHandlerConfiguration;
use JMS\Serializer\Context;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit;

use Dropelikeit\LaravelJmsSerializer\Config\Config;
use Dropelikeit\LaravelJmsSerializer\Http\Responses\ResponseFactory;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory;

use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Response\Item;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\Response\Item;
use JMS\Serializer\Annotation as Serializer;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory;

use JMS\Serializer\Annotation as Serializer;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory;

use ArrayIterator;
use Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Response\Item;
use Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\Response\Item;
use Webmozart\Assert\Assert;

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory\Response;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory\Response;

use JMS\Serializer\Annotation as Serializer;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace Dropelikeit\LaravelJmsSerializer\Tests\data\ResponseFactory;
namespace Dropelikeit\LaravelJmsSerializer\Tests\Unit\data\ResponseFactory;

use JMS\Serializer\Annotation\XmlAttribute;
use JMS\Serializer\Annotation\XmlRoot;
Expand Down