Merge pull request #104 from DuendeSoftware/ev/build-split-publish

Fix workflow for generating test reports
DuendeSoftware · Feb 14, 2025 · f8d454b · f8d454b
2 parents 860afc7 + 3febf2a
commit f8d454b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflow-gen/Program.cs b/.github/workflow-gen/Program.cs
@@ -262,7 +262,7 @@ internal static void StepGenerateReportFromTestArtifact(this Job job, Component
         job.Step()
             .Name($"Test report - {component.Name} - {testProject}")
             .Uses("dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5") // v1.9.1
-            .If($"event.workflow.name == '{component.CiWorkflowName}'")
+            .If($"github.event.workflow.name == '{component.CiWorkflowName}'")
             .With(
                 ("artifact", "test-results"),
                 ("name", $"Test Report - {testProject}"),

diff --git a/.github/workflows/generate-test-reports.yml b/.github/workflows/generate-test-reports.yml
@@ -21,7 +21,7 @@ jobs:
       packages: write
     steps:
     - name: Test report - ignore-this - IgnoreThis.Tests
-      if: event.workflow.name == 'ignore-this/ci'
+      if: github.event.workflow.name == 'ignore-this/ci'
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         artifact: test-results
@@ -31,7 +31,7 @@ jobs:
         fail-on-error: true
         fail-on-empty: true
     - name: Test report - access-token-management - AccessTokenManagement.Tests
-      if: event.workflow.name == 'access-token-management/ci'
+      if: github.event.workflow.name == 'access-token-management/ci'
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         artifact: test-results
@@ -41,7 +41,7 @@ jobs:
         fail-on-error: true
         fail-on-empty: true
     - name: Test report - identity-model - IdentityModel.Tests
-      if: event.workflow.name == 'identity-model/ci'
+      if: github.event.workflow.name == 'identity-model/ci'
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         artifact: test-results
@@ -51,7 +51,7 @@ jobs:
         fail-on-error: true
         fail-on-empty: true
     - name: Test report - identity-model-oidc-client - IdentityModel.OidcClient.Tests
-      if: event.workflow.name == 'identity-model-oidc-client/ci'
+      if: github.event.workflow.name == 'identity-model-oidc-client/ci'
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         artifact: test-results

diff --git a/access-token-management/src/AccessTokenManagement/Interfaces/ITokenRequestSynchronization.cs b/access-token-management/src/AccessTokenManagement/Interfaces/ITokenRequestSynchronization.cs
@@ -4,7 +4,8 @@
 namespace Duende.AccessTokenManagement;
 
 /// <summary>
-/// Service to provide synchronization to token endpoint requests
+/// Service to provide synchronization to token endpoint requests. When concurrent requests are made for the same token, this service
+/// de-duplicates the requests and ensures that only one request is made to the token endpoint.
 /// </summary>
 public interface ITokenRequestSynchronization
 {