Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpClientExtensions to dispose of HttpResponseMessage when it goes out of scope (Migrate IdentityModel PR 598) #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

damianh
Copy link
Member

@damianh damianh commented Feb 10, 2025

Migrates this PR from Identity Model repo by @gizmohd

@damianh damianh added area/identity-model Issues related to Identity Model priority/3 Medium impact/non-breaking The fix or change will not be a breaking one labels Feb 10, 2025
@damianh damianh added this to the im-7.1.0 milestone Feb 10, 2025
@damianh damianh self-assigned this Feb 10, 2025
@damianh damianh changed the title Migrate IdentityModel PR 598 https://github.com/IdentityModel/Identit… Migrate IdentityModel PR 598 Feb 10, 2025
@damianh
Copy link
Member Author

damianh commented Feb 10, 2025

@gizmohd seems we have a failing test where an HttpResponse object is being disposed but is used outside the disposal scope.

@damianh damianh changed the title Migrate IdentityModel PR 598 Fix HttpClientExtensions to dispose of HttpResponseMessage when it goes out of scope (Migrate IdentityModel PR 598) Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/identity-model Issues related to Identity Model impact/non-breaking The fix or change will not be a breaking one priority/3 Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant