Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zig_code_path quality-of-life improvements #500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

polvalente
Copy link

When I first tried zig_code_path, I tried using Path.join in the use opts.
This raised and I settled for a relative path (which I realize is the expected
code path).

Even if this change is not accepted, we can raise in a more informative way
in the new if is_binary(path) conditional.

Also, the put_attribute call makes it so that the code recompiles whenever
the zig source changes.

@polvalente
Copy link
Author

There's something I didn't find an easy fix for as well: If you pass zig_code_path, Zigler ends up creating separate .{module}.zig files, and all "go to file" links end up taking to that file.

This in turn were, multiple times, the cause for me having to apply a fix again because I applied it to the separate file instead of my source one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant