fix: iconenum was not exported properly

EAVFW · Nov 16, 2024 · 28acc5d · 28acc5d
1 parent 8c5a40e
commit 28acc5d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -5,7 +5,9 @@
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "type": "module",
-  "sideEffects": false,
+  "sideEffects": [
+    "src/services/index.ts"
+  ],
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",

diff --git a/packages/core/src/components/icons/index.ts b/packages/core/src/components/icons/index.ts
@@ -8,4 +8,4 @@ export { ImArrowRightIcon } from "./ImArrowRightIcon";
 export { RightArrow } from "./RightArrow";
 export { UserIcon } from "./UserIcon";
 export type { IconProps } from "./iconProps";
-export { type IconEnum, IconResolver } from "./IconResolver";
+export { IconEnum, IconResolver } from "./IconResolver";
diff --git a/packages/core/src/components/index.ts b/packages/core/src/components/index.ts
@@ -18,5 +18,5 @@ export { QuickFormContainer } from "./container/QuickFormContainer";
 export { ModernQuickFormContainer } from "./modern-container/ModernQuickformContainer";
 export { SlideRenderer } from "./renderers/slide-renderer/SlideRenderer";
 export { QuestionHeading } from "./question/components/QuestionHeading";
-export { IconResolver, type IconEnum } from "./icons";
+export { IconResolver, IconEnum } from "./icons";
 // import "./question/input-types";
diff --git a/...s/inputs/select/src/dropdown-options-list/dropdown-select-option/DropdownSelectOption.tsx b/...s/inputs/select/src/dropdown-options-list/dropdown-select-option/DropdownSelectOption.tsx
@@ -4,7 +4,7 @@ import styles from "./DropdownSelectOption.module.css";
 import { makeStyles, mergeClasses } from "@griffel/react";
 import { Checkmark } from "@eavfw/quickform-core/src/components/icons";
 import { shorthands } from "@fluentui/react-components";
-import { quickformtokens } from "@eavfw/quickform-core";
+import { quickformtokens, IconResolver } from "@eavfw/quickform-core";
 
 type DropdownSelectOptionProps = {
     readonly isSelected?: boolean;
@@ -62,8 +62,8 @@ export function DropdownSelectOption({
             onClick={onClick}
         >
             {children}
-            {isSelected && (
-                <Checkmark style={{display:"flex"}} color={quickformtokens.onSurface} size={"2rem"} />)}
+            {isSelected && <IconResolver icon="Checkmark" color={quickformtokens.onSurface} size={"2rem"} />}
+
         </span>
     );
 }