Remove NamedComponentParticleContainer (Use from AMReX) #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase and push a bit here while Andrew is OOO. |
ax3l
force-pushed
the
removed_named_component
branch
from
74c9db2 to
e95a324
Compare
ax3l
force-pushed
the
removed_named_component
branch
from
e95a324 to
f77bba9
Compare
5 tasks
ax3l
force-pushed
the
removed_named_component
branch
from
f77bba9 to
e174b85
Compare
ax3l
changed the title
ax3l
changed the title
ax3l
force-pushed
the
removed_named_component
branch
from
74414cd to
ddfbedf
Compare
|
Oh, a few names in output files are still accidentially renamed: |
|
Looks like the RZ tests are the only ones failing now. |
ax3l
added
the
changes input scripts / defaults
|
attn @roelof-groenewald @dpgrote @RemiLehe @clarkse this might slightly change Python scripts if you relied on adding runtime attributes (small change) or use the old naming queries (unlikely, but just want to raise). |
ax3l
reviewed
Feb 8, 2025
| @@ -141,7 +141,7 @@ Attribute name ``int``/``real`` Description Wher | |||
| Wheeler process physics is used. | |||
| ==================== ================ ================================== ===== ==== ====================== | |||
|
|
|||
| WarpX allows extra runtime attributes to be added to particle containers (through ``NewRealComp("attrname")`` or ``NewIntComp("attrname")``). | |||
| WarpX allows extra runtime attributes to be added to particle containers (through ``AddRealComp("attrname")`` or ``AddIntComp("attrname")``). | |||
There was a problem hiding this comment.
Most likely break that happens in user code:
NewRealComp -> AddRealComp
NewIntComp -> AddIntComp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This capability has been upstreamed to AMReX.
Depends on
PC::make_alikeAMReX-Codes/amrex#4322 / AMReX/pyAMReX/PICSAR: Weekly Update #5643