Introduce HandleSpacecharge
#842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to our `HandleWakefield` logic for particle tracking, this simplifies the central particle tracking loop by cleanly hiding implementation details in a separate function.
ax3l
commented
Feb 11, 2025
Comment on lines
113
to
+115
|
|
||
| // Space-charge calculation: turn off if there is only 1 particle | ||
| if (space_charge && | ||
| amr_data->track_particles.m_particle_container->TotalNumberOfParticles(true, false)) { | ||
|
|
||
| // transform from x',y',t to x,y,z | ||
| transformation::CoordinateTransformation( | ||
| *amr_data->track_particles.m_particle_container, | ||
| CoordSystem::t); | ||
|
|
||
| // Note: The following operation assume that | ||
| // the particles are in x, y, z coordinates. | ||
|
|
||
| // Resize the mesh, based on `m_particle_container` extent | ||
| ResizeMesh(); | ||
|
|
||
| // Redistribute particles in the new mesh in x, y, z | ||
| amr_data->track_particles.m_particle_container->Redistribute(); | ||
|
|
||
| // charge deposition | ||
| amr_data->track_particles.m_particle_container->DepositCharge( | ||
| amr_data->track_particles.m_rho, | ||
| amr_data->refRatio() | ||
| ); | ||
|
|
||
| // poisson solve in x,y,z | ||
| spacecharge::PoissonSolve( | ||
| *amr_data->track_particles.m_particle_container, | ||
| amr_data->track_particles.m_rho, | ||
| amr_data->track_particles.m_phi, | ||
| amr_data->refRatio() | ||
| ); | ||
|
|
||
| // calculate force in x,y,z | ||
| spacecharge::ForceFromSelfFields( | ||
| amr_data->track_particles.m_space_charge_field, | ||
| amr_data->track_particles.m_phi, | ||
| amr_data->Geom() | ||
| ); | ||
|
|
||
| // gather and space-charge push in x,y,z , assuming the space-charge | ||
| // field is the same before/after transformation | ||
| // TODO: This is currently using linear order. | ||
| spacecharge::GatherAndPush( | ||
| *amr_data->track_particles.m_particle_container, | ||
| amr_data->track_particles.m_space_charge_field, | ||
| amr_data->Geom(), | ||
| slice_ds | ||
| ); | ||
|
|
||
| // transform from x,y,z to x',y',t | ||
| transformation::CoordinateTransformation( | ||
| *amr_data->track_particles.m_particle_container, | ||
| CoordSystem::s | ||
| ); | ||
| } | ||
|
|
||
| // for later: original Impact implementation as an option | ||
| // Redistribute particles in x',y',t | ||
| // TODO: only needed if we want to gather and push space charge | ||
| // in x',y',t | ||
| // TODO: change geometry beforehand according to transformation | ||
| //m_particle_container->Redistribute(); | ||
| // | ||
| // in original Impact, we gather and space-charge push in x',y',t , | ||
| // assuming that the distribution did not change | ||
| // Space-charge calculation | ||
| particles::spacecharge::HandleSpacecharge(amr_data, [this](){ this->ResizeMesh(); }, slice_ds); |
There was a problem hiding this comment.
This is the location that this PR cleans up :)
cemitch99
reviewed
Feb 11, 2025
cemitch99
reviewed
Feb 11, 2025
Co-authored-by: Chad Mitchell <[email protected]>
cemitch99
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to our
HandleWakefieldlogic for particle tracking, this simplifies the central particle tracking loop by cleanly hiding implementation details in a separate function.