adjustments to scripts necessary for bot #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters for EESSI-pilot-install-software.sh and the handling of GENERIC option have been changed. Also a note where more sections for additional packages has been added. The README.md has been updated (newer pilot version). The 'exit 2' when /tmp directory does not support extended attributes or the command 'attr' was not found has been commented out. In 'install_software_layer.sh' the parameter "$@" was added to running the script "EESSI-pilot-install-software.sh".
boegel
reviewed
Oct 7, 2022
| @@ -26,7 +26,7 @@ if [ $? -eq 0 ]; then | |||
| attr -s test -V test $testfile > /dev/null | |||
| if [ $? -ne 0 ]; then | |||
| echo "ERROR: $EESSI_TMPDIR does not support extended attributes!" >&2 | |||
| exit 2 | |||
| #exit 2 | |||
There was a problem hiding this comment.
Rather than commenting this out, we should just drop this attr check, should be OK thanks to EESSI/filesystem-layer#125
I'll do that in a follow-up PR
boegel
approved these changes
Oct 7, 2022
boegel
changed the title
boegel
changed the title
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Oct 7, 2023
{2023.06}[foss/2022a] add NCO/5.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few changes to make the software layer compatible with EESSI/eessi-bot-software-layer/PR24.
This can be used as a base branch for adding new software packages to the EESSI pilot via the bot.
/tmpdirectory does not support extended attributes or the command 'attr' was not found has been commented out.